search

openshift / cluster-nfd-operator

The Cluster Node Feature Discovery operator manages detection of hardware features and configuration in a Openshift cluster.
Apache License 2.0
34 stars 42 forks source link

[release-4.12] OCPBUGS-5551: Fixing the discrepency between the NFD yaml and the API #304

Closed openshift-cherrypick-robot closed 1 year ago

openshift-cherrypick-robot commented 1 year ago

This is an automated cherry-pick of #303

/assign yevgeny-shnaidman

openshift-ci[bot] commented 1 year ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
yevgeny-shnaidman commented 1 year ago

/backport-risk-assessed

yevgeny-shnaidman commented 1 year ago

/cherry-pick-approve

yevgeny-shnaidman commented 1 year ago

/backport-risk-assess

yevgeny-shnaidman commented 1 year ago

/approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-nfd-operator/blob/release-4.12/OWNERS)~~ [yevgeny-shnaidman] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yevgeny-shnaidman commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@yevgeny-shnaidman: No Jira bug is referenced in the title of this pull request. To reference a bug, add 'OCPBUGS-XXX:' to the title of this pull request and request another bug refresh with /jira refresh.

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/304#issuecomment-1381751606): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
yevgeny-shnaidman commented 1 year ago

/retitle [release-4.12] OCPBUGS-5551 Fixing the discrepency between the NFD yaml and the API

yevgeny-shnaidman commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@yevgeny-shnaidman: No Jira bug is referenced in the title of this pull request. To reference a bug, add 'OCPBUGS-XXX:' to the title of this pull request and request another bug refresh with /jira refresh.

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/304#issuecomment-1381752923): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/304): >[release-4.12] OCPBUGS-5551 Fixing the discrepency between the NFD yaml and the API Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
yevgeny-shnaidman commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@yevgeny-shnaidman: No Jira bug is referenced in the title of this pull request. To reference a bug, add 'OCPBUGS-XXX:' to the title of this pull request and request another bug refresh with /jira refresh.

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/304#issuecomment-1381753268): > >/jira refresh > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
yevgeny-shnaidman commented 1 year ago

/retitle [release-4.12] OCPBUGS-5551: Fixing the discrepency between the NFD yaml and the API

openshift-ci[bot] commented 1 year ago

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/304): >[release-4.12] OCPBUGS-5551: Fixing the discrepency between the NFD yaml and the API Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-5551, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/304): >This is an automated cherry-pick of #303 > >/assign yevgeny-shnaidman Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
yevgeny-shnaidman commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@yevgeny-shnaidman: This pull request references Jira Issue OCPBUGS-5551, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.12.0) matches configured target version for branch (4.12.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-5822](https://issues.redhat.com//browse/OCPBUGS-5822) is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-5822](https://issues.redhat.com//browse/OCPBUGS-5822) targets the "4.13.0" version, which is one of the valid target versions: 4.13.0 * bug has dependents

Requesting review from QA contact: /cc @wabouhamad

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/304#issuecomment-1381756700): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
yevgeny-shnaidman commented 1 year ago

/label backport-risk-assessed

openshift-ci[bot] commented 1 year ago

@yevgeny-shnaidman: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers]

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/304#issuecomment-1381785934): >/label backport-risk-assessed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
wabouhamad commented 1 year ago

/lgtm

openshift-ci-robot commented 1 year ago

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-5551 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/304): >This is an automated cherry-pick of #303 > >/assign yevgeny-shnaidman Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 1 year ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-nfd-operator-container-v4.12.0-202305022015.p0.g3d08a74.assembly.stream for distgit cluster-nfd-operator. All builds following this will include this PR.