search

openshift / cluster-nfd-operator

The Cluster Node Feature Discovery operator manages detection of hardware features and configuration in a Openshift cluster.
Apache License 2.0
34 stars 42 forks source link

Removing duplicate ServiceMonitor during bundle creation #306

Closed yevgeny-shnaidman closed 1 year ago

yevgeny-shnaidman commented 1 year ago

Currently prometheus is customized both from config/manifests and from config/default, which renderes 2 identical ServiceMonitors. This PR removes prometheus rendering from config/manifests

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-nfd-operator/blob/master/OWNERS)~~ [yevgeny-shnaidman] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yevgeny-shnaidman commented 1 year ago

/assign @ybettan

yevgeny-shnaidman commented 1 year ago

/assign @chr15p

ybettan commented 1 year ago

/lgtm

openshift-ci[bot] commented 1 year ago

@yevgeny-shnaidman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).