search

openshift / cluster-nfd-operator

The Cluster Node Feature Discovery operator manages detection of hardware features and configuration in a Openshift cluster.
Apache License 2.0
34 stars 42 forks source link

Fixing Topology DS pods startup #314

Closed yevgeny-shnaidman closed 1 year ago

yevgeny-shnaidman commented 1 year ago

Fixes: 1) removing server argument - no longer needed or supported 2) changing kubelet-config-file argument to kubelet-config-uri and define scheme as file 3) fix topology CRD - add alpha2 version support

yevgeny-shnaidman commented 1 year ago

/assign @chr15p

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-nfd-operator/blob/master/OWNERS)~~ [yevgeny-shnaidman] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chr15p commented 1 year ago

/lgtm

openshift-ci-robot commented 1 year ago

/retest-required

Remaining retests: 0 against base HEAD ca7be2ac2f3dec9dc3df8b27b9768ddff039bd1f and 2 for PR HEAD 8adaefa6efcfcb0ea9a721e582b25b2af325a4f7 in total

yevgeny-shnaidman commented 1 year ago

/test e2e-aws

yevgeny-shnaidman commented 1 year ago

/test e2e-aws

openshift-ci[bot] commented 1 year ago

@yevgeny-shnaidman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
ybettan commented 1 year ago

/lgtm

yevgeny-shnaidman commented 1 year ago

/cherry-pick release-4.13

openshift-cherrypick-robot commented 1 year ago

@yevgeny-shnaidman: new pull request created: #315

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/314#issuecomment-1477457918): >/cherry-pick release-4.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.