openshift / cluster-nfd-operator

The Cluster Node Feature Discovery operator manages detection of hardware features and configuration in a Openshift cluster.
Apache License 2.0
34 stars 42 forks source link

Fixing topology pod creation failure #329

Closed yevgeny-shnaidman closed 1 year ago

yevgeny-shnaidman commented 1 year ago

1) mapping host's device-plugins directory into pod, since it is needed now by the kubelet notifier 2) adding topology configmap to the build/assests 3) fixing handling/creation of configmap in the operator. currently it is hardcoded supporting only nfd-worker configmap, and this PR allows supporting of addition configmaps

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-nfd-operator/blob/master/OWNERS)~~ [yevgeny-shnaidman] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yevgeny-shnaidman commented 1 year ago

/test unit

ybettan commented 1 year ago

/lgtm

openshift-ci-robot commented 1 year ago

/retest-required

Remaining retests: 0 against base HEAD 178530f99dc47c82bb3b3beecbedefd416cb004d and 2 for PR HEAD e90d9f1faf1b82511cf3854221b6a3449ead2b3e in total

openshift-ci[bot] commented 1 year ago

@yevgeny-shnaidman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).