search

openshift / cluster-nfd-operator

The Cluster Node Feature Discovery operator manages detection of hardware features and configuration in a Openshift cluster.
Apache License 2.0
34 stars 42 forks source link

Adding permission to master service account #354

Closed yevgeny-shnaidman closed 7 months ago

yevgeny-shnaidman commented 7 months ago

adding permissions for node listing and for handling nodefeature CRs

yevgeny-shnaidman commented 7 months ago

/assign @chr15p

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-nfd-operator/blob/master/OWNERS)~~ [yevgeny-shnaidman] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chr15p commented 7 months ago

/lgtm

openshift-ci[bot] commented 7 months ago

@yevgeny-shnaidman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
yevgeny-shnaidman commented 7 months ago

/cherry-pick release-4.15

openshift-cherrypick-robot commented 7 months ago

@yevgeny-shnaidman: new pull request created: #355

In response to [this](https://github.com/openshift/cluster-nfd-operator/pull/354#issuecomment-1952418456): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 7 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-nfd-operator-container-v4.16.0-202402191409.p0.g656d001.assembly.stream.el9 for distgit cluster-nfd-operator. All builds following this will include this PR.