search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

CNF-11977: e2e: Added mixed cpus negative tests #1026

Closed rbaturov closed 5 months ago

rbaturov commented 7 months ago

Added the following tests:

openshift-ci-robot commented 7 months ago

@rbaturov: This pull request references CNF-11977 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1026): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 7 months ago

@rbaturov: This pull request references CNF-11977 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1026): >Added the following tests: >* A best-effort pod effort can't be deployed with shared-cpus resource >* A burstable pod can't be deployed with shared-cpus resource >* A pod with shared-cpus resource can't be deployed in ns without mixedcpus annotation. >* A pod with an invalid resource openshift.io/enable-shared-cpus != 1, should fail. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yanirq commented 6 months ago

/retest

rbaturov commented 6 months ago

/retest-required

rbaturov commented 6 months ago

/retest-required

rbaturov commented 6 months ago

@Tal-or Can you please review this?

rbaturov commented 6 months ago

Good work, nit comments

Thank you! Will update the code according to these comments.

rbaturov commented 6 months ago

/unhold

Tal-or commented 6 months ago

/lgtm

rbaturov commented 6 months ago

/retest-required

Tal-or commented 5 months ago

/retest

ffromani commented 5 months ago

/hold

ffromani commented 5 months ago

/approve

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, rbaturov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [ffromani] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ffromani commented 5 months ago

/hold cancel

actually no blocking comments

openshift-ci-robot commented 5 months ago

/retest-required

Remaining retests: 0 against base HEAD 6d2e11aec3451261bc4bcd8b4ed37a2146b79198 and 2 for PR HEAD e7b0f3ca9bded1d9f88efada64edee7fae7b2f02 in total

rbaturov commented 5 months ago

/retest-required

rbaturov commented 5 months ago

/retest-required

openshift-ci[bot] commented 5 months ago

@rbaturov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).