search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

[release-4.13] OCPBUGS-31936: Scheduler plugin: ignore IRQs #1027

Closed yanirq closed 7 months ago

yanirq commented 7 months ago

Manual cherry pick of https://github.com/openshift/cluster-node-tuning-operator/pull/1023

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/release-4.13/OWNERS)~~ [yanirq] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yanirq commented 7 months ago

/jira cherrypick OCPBUGS-31844

openshift-ci-robot commented 7 months ago

@yanirq: Jira Issue OCPBUGS-31844 has been cloned as Jira Issue OCPBUGS-31936. Will retitle bug to link to clone. /retitle OCPBUGS-31936: Scheduler plugin: ignore IRQs

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1027#issuecomment-2045441982): >/jira cherrypick OCPBUGS-31844 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 7 months ago

@yanirq: This pull request references Jira Issue OCPBUGS-31936, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1027): >Manual cherry pick of https://github.com/openshift/cluster-node-tuning-operator/pull/1023 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 7 months ago

@yanirq: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
yanirq commented 7 months ago

/label backport-risk-assessed

yanirq commented 7 months ago

/cc @mrniranjan

mrniranjan commented 7 months ago

/label cherry-pick-approved

mrniranjan commented 7 months ago

/jira refresh

openshift-ci-robot commented 7 months ago

@mrniranjan: This pull request references Jira Issue OCPBUGS-31936, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1027#issuecomment-2050926432): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
MarSik commented 7 months ago

/jira refresh /lgtm

openshift-ci-robot commented 7 months ago

@MarSik: An error was encountered searching for dependent bug OCPBUGS-31844 for bug OCPBUGS-31936 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message. No response returned: Get "https://issues.redhat.com/rest/api/2/issue/OCPBUGS-31844": GET https://issues.redhat.com/rest/api/2/issue/OCPBUGS-31844 giving up after 5 attempt(s)

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1027#issuecomment-2051136300): >/jira refresh >/lgtm Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
MarSik commented 7 months ago

/jira refresh

openshift-ci-robot commented 7 months ago

@MarSik: This pull request references Jira Issue OCPBUGS-31936, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.13.z) matches configured target version for branch (4.13.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-31844](https://issues.redhat.com//browse/OCPBUGS-31844) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-31844](https://issues.redhat.com//browse/OCPBUGS-31844) targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (mniranja@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1027#issuecomment-2051137954): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 7 months ago

@yanirq: Jira Issue OCPBUGS-31936: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31936 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1027): >Manual cherry pick of https://github.com/openshift/cluster-node-tuning-operator/pull/1023 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 7 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.13.0-202404120545.p0.gae78290.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.

yanirq commented 7 months ago

/cherry-pick release-4.12

openshift-cherrypick-robot commented 7 months ago

@yanirq: #1027 failed to apply on top of branch "release-4.12":

Applying: Scheduler plugin: ignore IRQs
Using index info to reconstruct a base tree...
M   assets/performanceprofile/tuned/openshift-node-performance
M   test/e2e/performanceprofile/testdata/render-expected-output/manual_tuned.yaml
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/performanceprofile/testdata/render-expected-output/manual_tuned.yaml
CONFLICT (content): Merge conflict in test/e2e/performanceprofile/testdata/render-expected-output/manual_tuned.yaml
Auto-merging assets/performanceprofile/tuned/openshift-node-performance
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Scheduler plugin: ignore IRQs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1027#issuecomment-2053996136): >/cherry-pick release-4.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.