openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

No-Jira: E2E: Extend mixed cpus tests to test cpu load balancing annotation #1028

Closed mrniranjan closed 6 months ago

mrniranjan commented 7 months ago

/retest-required

mrniranjan commented 7 months ago

/retest-required

Tal-or commented 7 months ago

Is this test works for both cgroupv1 and v2?

mrniranjan commented 7 months ago

Is this test works for both cgroupv1 and v2?

I tested for v2 , need to test for v1

Tal-or commented 7 months ago
  [FAILED] in [It] - /go/src/github.com/openshift/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/11_mixedcpus/mixedcpus.go:156 @ 04/15/24 11:11:13.999
  STEP: executing teardown - revert profile "performance" back to its intial state @ 04/15/24 11:11:21.016
  Apr 15 11:11:21.079: [INFO]: MCP "worker-cnf" is targeting 1 node(s)
  Apr 15 11:11:51.108: [INFO]: MCP "worker-cnf" is targeting 1 node(s)
• [FAILED] [465.521 seconds]
Mixedcpus single workload - request validation when workloads requests access for shared cpus [It] verify cpu load balancing still works with mixed cpus
/go/src/github.com/openshift/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/11_mixedcpus/mixedcpus.go:145
  [FAILED] Unexpected error:
      <*errors.errorString | 0xc0002a4cc0>: 
      failed to create pod. pod=performance-addon-operators-testing/test-cd8w5, podStatus={Pending [{PodScheduled False 0001-01-01 00:00:00 +0000 UTC 2024-04-15 11:10:14 +0000 UTC Unschedulable 0/6 nodes are available: 1 Insufficient cpu, 2 node(s) didn't match Pod's node affinity/selector, 3 node(s) had untolerated taint {node-role.kubernetes.io/master: }. no new claims to deallocate, preemption: 0/6 nodes are available: 1 No preemption victims found for incoming pod, 5 Preemption is not helpful for scheduling.}]     []  [] <nil> [] [] Guaranteed []  []} err=context deadline exceeded
      {
          s: "failed to create pod. pod=performance-addon-operators-testing/test-cd8w5, podStatus={Pending [{PodScheduled False 0001-01-01 00:00:00 +0000 UTC 2024-04-15 11:10:14 +0000 UTC Unschedulable 0/6 nodes are available: 1 Insufficient cpu, 2 node(s) didn't match Pod's node affinity/selector, 3 node(s) had untolerated taint {node-role.kubernetes.io/master: }. no new claims to deallocate, preemption: 0/6 nodes are available: 1 No preemption victims found for incoming pod, 5 Preemption is not helpful for scheduling.}]     []  [] <nil> [] [] Guaranteed []  []} err=context deadline exceeded",
      }
  occurred
  In [It] at: /go/src/github.com/openshift/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/11_mixedcpus/mixedcpus.go:156 @ 04/15/24 11:11:13.999
mrniranjan commented 7 months ago

/retest-required

Tal-or commented 7 months ago

/lgtm @mrniranjan would a single cpu work on the d/s pipeline as well? it would require disable the SMT alignment under the cpu manager

mrniranjan commented 7 months ago

/lgtm @mrniranjan would a single cpu work on the d/s pipeline as well? it would require disable the SMT alignment under the cpu manager

Can i modify the test case to pick two cpus if the number of online cpus is more than 4 ?

Tal-or commented 7 months ago

/lgtm @mrniranjan would a single cpu work on the d/s pipeline as well? it would require disable the SMT alignment under the cpu manager

Can i modify the test case to pick two cpus if the number of online cpus is more than 4 ?

Sure, I suggested that when we were discussing offline. we can make it as a general enhancement to all the tests on separate PR

openshift-ci-robot commented 6 months ago

@mrniranjan: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1028): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ffromani commented 6 months ago

/approve

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, mrniranjan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [ffromani] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yanirq commented 6 months ago

/label acknowledge-critical-fixes-only

test code. no core payload

openshift-ci-robot commented 6 months ago

/retest-required

Remaining retests: 0 against base HEAD b3b634d12117b880f5c33deba1b48465e1be31c1 and 2 for PR HEAD 771cfa02dce0b352d814caba3ddfb9f2dbbd6020 in total

mrniranjan commented 6 months ago

/test e2e-hypershift

mrniranjan commented 6 months ago

/retest-required

mrniranjan commented 6 months ago

/retest-required

openshift-ci[bot] commented 6 months ago

@mrniranjan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 6 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.17.0-202405201608.p0.gde2ccbc.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.