search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

NO-JIRA: pao:controller: remove depracated function #1039

Closed Tal-or closed 7 months ago

Tal-or commented 7 months ago

deleteDeprecatedComponents function was added in older releases to overcome this issue: https://github.com/openshift-kni/performance-addon-operators/pull/538

This is no longer relevant and can be removed since it was intented to fix an upgrade issue from an old version.

openshift-ci-robot commented 7 months ago

@Tal-or: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1039): >`deleteDeprecatedComponents` function was added in older releases to overcome this issue: >https://github.com/openshift-kni/performance-addon-operators/pull/538 > >This is no longer relevant and can be removed since it was intented to fix an upgrade issue from an old version. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ffromani commented 7 months ago

/approve

I agree this function is both deprecated and can be removed

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [ffromani] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yanirq commented 7 months ago

/lgtm

openshift-ci-robot commented 7 months ago

/retest-required

Remaining retests: 0 against base HEAD 0751f57db0307337b898d0dca44d9d204b5812eb and 2 for PR HEAD 7d940d778a98c179241cea8a49bd12344057867a in total

Tal-or commented 7 months ago

/retest

Tal-or commented 7 months ago

/retest

openshift-ci[bot] commented 7 months ago

@Tal-or: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 7 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202404181209.p0.g42972b5.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.