search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

CNF-11559: [Part 3/3] Hypershift PAO adoption #1057

Closed Tal-or closed 5 months ago

Tal-or commented 6 months ago

This PR provides the actual support of PAO/NTO over hypershift platform. The PR follows the enhancement: https://github.com/openshift/enhancements/pull/1244

More details in the commits themselves.

Additional gaps which should be addressed on separate PRs, but listed here for transparency:

openshift-ci-robot commented 6 months ago

@Tal-or: This pull request references CNF-11559 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1057): >This PR provides the actual support of PAO/NTO over hypershift platform. >The PR follows the enhancement: https://github.com/openshift/enhancements/pull/1244 > >More details in the commits themselves. > >- [X] Implementation >- [ ] E2E testing > >Additional gaps which should be addressed but on separate PRs: >- Status reporting >- Retrieve `containerruntimeconfig` information Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Tal-or commented 6 months ago

/retest

openshift-ci-robot commented 6 months ago

@Tal-or: This pull request references CNF-11559 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1057): >This PR provides the actual support of PAO/NTO over hypershift platform. >The PR follows the enhancement: https://github.com/openshift/enhancements/pull/1244 > >More details in the commits themselves. > >- [X] Implementation >- [ ] E2E testing > >Additional gaps which should be addressed but on separate PRs: >- Status reporting >- Retrieve `containerruntimeconfig` information >- Feature Gate support Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 6 months ago

@Tal-or: This pull request references CNF-11559 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1057): >This PR provides the actual support of PAO/NTO over hypershift platform. >The PR follows the enhancement: https://github.com/openshift/enhancements/pull/1244 > >More details in the commits themselves. > >- [X] Implementation >- [ ] E2E testing > >Additional gaps which should be addressed but on separate PRs: >- Status reporting [CNF-12680](https://issues.redhat.com/browse/CNF-12680) >- Retrieve `containerruntimeconfig` information [CNF-11845](https://issues.redhat.com/browse/) >- Feature Gate support [CNF-12711](https://issues.redhat.com/browse/CNF-12711) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 6 months ago

@Tal-or: This pull request references CNF-11559 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1057): >This PR provides the actual support of PAO/NTO over hypershift platform. >The PR follows the enhancement: https://github.com/openshift/enhancements/pull/1244 > >More details in the commits themselves. > >- [X] Implementation >- [ ] E2E testing > >Additional gaps which should be addressed on separate PRs, but listed here for transparency: >- Status reporting [CNF-12680](https://issues.redhat.com/browse/CNF-12680) >- Retrieve `containerruntimeconfig` information [CNF-11845](https://issues.redhat.com/browse/) >- Feature Gate support [CNF-12711](https://issues.redhat.com/browse/CNF-12711) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Tal-or commented 6 months ago

depends on: https://github.com/openshift/cluster-node-tuning-operator/pull/1004

openshift-ci-robot commented 6 months ago

@Tal-or: This pull request references CNF-11559 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1057): >This PR provides the actual support of PAO/NTO over hypershift platform. >The PR follows the enhancement: https://github.com/openshift/enhancements/pull/1244 > >More details in the commits themselves. > >- [X] Implementation >- [x] E2E testing > >Additional gaps which should be addressed on separate PRs, but listed here for transparency: >- Status reporting [CNF-12680](https://issues.redhat.com/browse/CNF-12680) >- Retrieve `containerruntimeconfig` information [CNF-11845](https://issues.redhat.com/browse/) >- Feature Gate support [CNF-12711](https://issues.redhat.com/browse/CNF-12711) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Tal-or commented 6 months ago

/retest

Tal-or commented 6 months ago

/test e2e-hypershift-pao

Tal-or commented 6 months ago

/retest

Tal-or commented 6 months ago

/retest

Tal-or commented 5 months ago

/retest

Tal-or commented 5 months ago

/retest

Tal-or commented 5 months ago

/retest

openshift-ci-robot commented 5 months ago

@Tal-or: This pull request references CNF-11559 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1057): >This PR provides the actual support of PAO/NTO over hypershift platform. >The PR follows the enhancement: https://github.com/openshift/enhancements/pull/1244 > >More details in the commits themselves. > >- [X] Implementation > >Additional gaps which should be addressed on separate PRs, but listed here for transparency: >- Status reporting [CNF-12680](https://issues.redhat.com/browse/CNF-12680) >- Retrieve `containerruntimeconfig` information [CNF-11845](https://issues.redhat.com/browse/) >- Feature Gate support [CNF-12711](https://issues.redhat.com/browse/CNF-12711) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 5 months ago

@Tal-or: This pull request references CNF-11559 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1057): >This PR provides the actual support of PAO/NTO over hypershift platform. >The PR follows the enhancement: https://github.com/openshift/enhancements/pull/1244 > >More details in the commits themselves. > >- [X] Implementation >- [X] E2E config suite adoption > >Additional gaps which should be addressed on separate PRs, but listed here for transparency: >- Status reporting [CNF-12680](https://issues.redhat.com/browse/CNF-12680) >- Retrieve `containerruntimeconfig` information [CNF-11845](https://issues.redhat.com/browse/) >- Feature Gate support [CNF-12711](https://issues.redhat.com/browse/CNF-12711) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Tal-or commented 5 months ago

/jira refresh

openshift-ci-robot commented 5 months ago

@Tal-or: This pull request references CNF-11559 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1057#issuecomment-2144556267): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yanirq commented 5 months ago

/payload 4.17 ci blocking

openshift-ci[bot] commented 5 months ago

@yanirq: trigger 4 job(s) of type blocking for the ci release of OCP 4.17

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/de9e9b60-2188-11ef-9b8a-9c120e87cc32-0

Tal-or commented 5 months ago

/payload 4.17 ci blocking

openshift-ci[bot] commented 5 months ago

@Tal-or: trigger 4 job(s) of type blocking for the ci release of OCP 4.17

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ae8ea980-219a-11ef-9cc4-caf4dc0e306d-0

Tal-or commented 5 months ago

/retest

Tal-or commented 5 months ago

/test e2e-hypershift

ffromani commented 5 months ago

@Tal-or looks good, thanks for your work!

Tal-or commented 5 months ago

/retest

Tal-or commented 5 months ago

/retest

Tal-or commented 5 months ago

Depends on https://github.com/openshift/release/pull/52876

jmencak commented 5 months ago

/retest

Tal-or commented 5 months ago

/test e2e-hypershift

ffromani commented 5 months ago

/hold cancel

because missing approval so no risk of premature merge

ffromani commented 5 months ago

/lgtm

yanirq commented 5 months ago

/approve

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tal-or, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [yanirq] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 5 months ago

@Tal-or: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 5 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.17.0-202406101017.p0.g4d6cb12.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.