openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

[release-4.15] OCPBUGS-33929: Negative net interface name does not reduce queues #1062

Closed openshift-cherrypick-robot closed 6 months ago

openshift-cherrypick-robot commented 6 months ago

This is an automated cherry-pick of #973

/assign MarSik

/cherrypick release-4.14

openshift-ci-robot commented 6 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-30111 has been cloned as Jira Issue OCPBUGS-33929. Will retitle bug to link to clone. /retitle [release-4.15] OCPBUGS-33929: Negative net interface name does not reduce queues

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1062): >This is an automated cherry-pick of #973 > >/assign MarSik > >/cherrypick release-4.14 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 6 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-33929, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1062): >This is an automated cherry-pick of #973 > >/assign MarSik > >/cherrypick release-4.14 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot Once this PR has been reviewed and has the lgtm label, please assign dagrayvid for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/release-4.15/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
MarSik commented 6 months ago

/jira refresh

openshift-ci-robot commented 6 months ago

@MarSik: This pull request references Jira Issue OCPBUGS-33929, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.z) matches configured target version for branch (4.15.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-30111](https://issues.redhat.com//browse/OCPBUGS-30111) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-30111](https://issues.redhat.com//browse/OCPBUGS-30111) targets the "4.16.0" version, which is one of the valid target versions: 4.16.0 * bug has dependents

Requesting review from QA contact: /cc @gsr-shanks

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1062#issuecomment-2119848894): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 6 months ago

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-pao 7d74e484ff3b47a845235a98d9ee6746e83128df link true /test e2e-gcp-pao
ci/prow/vet 7d74e484ff3b47a845235a98d9ee6746e83128df link true /test vet

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
MarSik commented 6 months ago

/label backport-risk-assessed

mrniranjan commented 6 months ago

/label cherry-pick-approved

MarSik commented 6 months ago

The automated cherry-pick cannot be merged due to a test API change. This PR is replaced with a manual one https://github.com/openshift/cluster-node-tuning-operator/pull/1066

/close

openshift-ci-robot commented 6 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-33929. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1062): >This is an automated cherry-pick of #973 > >/assign MarSik > >/cherrypick release-4.14 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 6 months ago

@MarSik: Closed this PR.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1062#issuecomment-2126553681): >The automated cherry-pick cannot be merged due to a test API change. This PR is replaced with a manual one https://github.com/openshift/cluster-node-tuning-operator/pull/1066 > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.