OCPBUGS-28647: tuned: operand: deferred updates prepare: cleanups from #1019

[ffromani]

The PR #1019 includes a fair bit of cleanup and preparation code which may merge independently because these improvements are liked anyway, and doing so would simplify the review and finalization of #1019 itself.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [ffromani] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[ffromani]

Thank you for the changes. This is a definite improvement over the current code. I'm only not sure why one of the log messages was dropped. Is it no longer useful?

No, I just fumbled up the rebase :) fixed

[ffromani]

Thank you for the changes. This is a definite improvement over the current code. I'm only not sure why one of the log messages was dropped. Is it no longer useful?

No, I just fumbled up the rebase :) fixed

aaaaand I fumbled again. It should be OK now.

[ffromani]

/retest

[jmencak]

/lgtm I believe we can use the same OCPBUG for this as #1019.

[openshift-ci-robot]

@ffromani: This pull request references Jira Issue OCPBUGS-28647, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @shajmakh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1073): >The PR #1019 includes a fair bit of cleanup and preparation code which may merge independently because these improvements are [liked anyway](https://github.com/openshift/cluster-node-tuning-operator/pull/1019#pullrequestreview-2073382408), and doing so would simplify the review and finalization of #1019 itself. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[ffromani]

/lgtm I believe we can use the same OCPBUG for this as #1019.

thanks, done

[ffromani]

/jira refresh

[openshift-ci-robot]

@ffromani: This pull request references Jira Issue OCPBUGS-28647, which is valid.

3 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @shajmakh

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1073#issuecomment-2151434436): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-ci[bot]]

@ffromani: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[openshift-ci-robot]

@ffromani: Jira Issue OCPBUGS-28647: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

• openshift/cluster-node-tuning-operator#1019 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-28647 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1073): >The PR #1019 includes a fair bit of cleanup and preparation code which may merge independently because these improvements are [liked anyway](https://github.com/openshift/cluster-node-tuning-operator/pull/1019#pullrequestreview-2073382408), and doing so would simplify the review and finalization of #1019 itself. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.17.0-202406061212.p0.g6d2e11a.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.