search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

NO-JIRA:Dockerfile:bump go-builder to 1.22 #1078

Closed Tal-or closed 5 months ago

Tal-or commented 5 months ago

In the go.mod file, we are using the toolchain directive, which is not recognized by golang 1.20.

openshift-ci-robot commented 5 months ago

@Tal-or: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1078): >In the `go.mod` file, we are using the `toolchain` directive, which is not recognized by golang 1.20. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 5 months ago

@Tal-or: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
ffromani commented 5 months ago

/lgtm

/cc @jmencak for approval

jmencak commented 5 months ago

/approve At some point, we should remove the "Upstream" Dockerfile. Dockerfile.rhel9 is now badly named and will build with CentOS stream too and also pull upstream TuneD. There is really no need to keep two (three Dockerfile.rhel8) Containerfiles around. Adding to my TODO (cleanup list) unless someone else wants to pick this up.

openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [jmencak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment