CNF-13193: Update NTO Hugepages size validation

fontivan commented 5 months ago

Include valid sizes for both x86 and aarch64 in the validation check
Included notes for aarch64 where each kernel page size includes only a single valid hugepage size
After discusion on Slack I have also added some additional validations: -- Verify all nodes in the list have the same cpu architecture -- Verify all nodes in the list have the same cpu capacity -- Verify that the selected hugepage size is valid for the cpu architecture

openshift-ci-robot commented 5 months ago

@fontivan: This pull request references CNF-13193 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1086): >- Include valid sizes for both x86 and aarch64 in the validation check >- Included notes for aarch64 where each kernel page size includes only a single valid hugepage size Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci[bot] commented 5 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci-robot commented 5 months ago

@fontivan: This pull request references CNF-13193 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1086): >- Include valid sizes for both x86 and aarch64 in the validation check >- Included notes for aarch64 where each kernel page size includes only a single valid hugepage size >- After discusion on Slack I have also added some additional validations: >-- Verify all nodes in the list have the same cpu architecture >-- Verify all nodes in the list have the same cpu capacity >-- Verify that the selected hugepage size is valid for the cpu architecture Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

MarSik commented 5 months ago

I like the direction, we should make sure we are not adding too many repeated API server requests though (too many node listings for example).

fontivan commented 3 months ago

/test e2e-gcp-pao

fontivan commented 3 months ago

/retest

fontivan commented 3 months ago

/retest

yanirq commented 2 months ago

/retest

fontivan commented 2 months ago

/test e2e-gcp-pao

fontivan commented 2 months ago

/retest

fontivan commented 2 months ago

/retest

fontivan commented 2 months ago

/retest