Open SargunNarula opened 5 months ago
@SargunNarula: This pull request explicitly references no jira issue.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: SargunNarula Once this PR has been reviewed and has the lgtm label, please assign marsik for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
@SargunNarula: This pull request references Jira Issue OCPBUGS-35911, which is valid. The bug has been moved to the POST state.
No GitHub users were found matching the public email listed for the QA contact in Jira (snarula@redhat.com), skipping review request.
The bug has been updated to refer to the pull request using the external bug tracker.
@SargunNarula: This pull request references Jira Issue OCPBUGS-35911, which is valid.
No GitHub users were found matching the public email listed for the QA contact in Jira (snarula@redhat.com), skipping review request.
looks good to me from my side.
@SargunNarula: all tests passed!
Full PR test history. Your PR dashboard.
@ffromani The original issue identified was that when launching a guaranteed pod running a cyclic test, the runc container creation process was observed to be running on isolated CPUs. This process inadvertently utilized the CPUs allocated to the cyclic test.
The resolution involved ensuring that the cpuset.cpus configuration is passed during container creation.
Additionally, since runc follows a two-step creation process, the initialization process (executed as /usr/bin/pod, which is a symlink to /usr/bin/runc) is started within a container. This container is assigned the cpuset.cpus values. This behavior can be confirmed by examining the config.json of the initialization container to verify that the appropriate CPU allocation is applied, reserved CPUs in the case of a guaranteed pod, or all available CPUs in the case of a Best-Effort (BE) pod.
Reference:
Based on these observations, the current patch may not effectively validate this scenario. I will work on a revised patch to accurately verify the CPUs being utilized.
Adding a test to verify that runc does not use CPUs assigned to guaranteed pods.
Original bug link - https://bugzilla.redhat.com/show_bug.cgi?id=1910386