search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

No-JIRA: e2e:run-test.sh: match ginkgo CLI to ginkgo package #1092

Closed Tal-or closed 4 months ago

Tal-or commented 5 months ago

We are usually having a mismatch between the ginkgo CLI and ginkgo package, because we are updating the ginkgo package on the go.mod but forget to do the same on our test's script. something like:

Ginkgo detected a version mismatch between the Ginkgo CLI and the version of Ginkgo imported by your packages:
  Ginkgo CLI Version:
    2.6.1
  Mismatched package versions found:
    2.17.1 used by 0_config, 1_performance, 6_mustgather_testing, 10_performance_ppc

let's automate the process to save some work and avoid bugs that might happens due to breaking changes between versions which are not matching

openshift-ci-robot commented 5 months ago

@Tal-or: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1092): >We are usually having a mismatch between the ginkgo CLI and ginkgo package, because we are updating the ginkgo package on the go.mod but forget to do the same on out test's script. >something like: >``` >Ginkgo detected a version mismatch between the Ginkgo CLI and the version of Ginkgo imported by your packages: > Ginkgo CLI Version: > 2.6.1 > Mismatched package versions found: > 2.17.1 used by 0_config, 1_performance, 6_mustgather_testing, 10_performance_ppc >``` > >let's automate the process to save some work and avoid bugs that might happens due to breaking changes between versions which are not matching Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [ffromani] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 5 months ago

/retest-required

Remaining retests: 0 against base HEAD 6de4dcaca0ef786fe617f5db885554e290b52e16 and 2 for PR HEAD 29b76dffa7e99a2cccb21eb9affece2c04791620 in total

Tal-or commented 4 months ago

/retest

openshift-ci-robot commented 4 months ago

/retest-required

Remaining retests: 0 against base HEAD 0a2f7b33d52a21053e3b140ed4035ff8581f5a0a and 1 for PR HEAD 29b76dffa7e99a2cccb21eb9affece2c04791620 in total

openshift-ci[bot] commented 4 months ago

@Tal-or: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 4 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.17.0-202406262328.p0.g4b9ac52.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.