search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

NO-JIRA: hypershift: check updatingConfig condition to be false instead of missing #1096

Closed rbaturov closed 4 months ago

rbaturov commented 4 months ago

Due to the latest changes in the hypershift nodepool conditions API (https://github.com/openshift/hypershift/commit/05a7fa17c8156585658b72fa9453a569963ee2bd) in order to check that the tuning has completed and the nodepool is ready, we need to change our check accordingly - check that the condition is false instead of missing.

openshift-ci-robot commented 4 months ago

@rbaturov: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1096): >Due to the latest changes in the hypershift nodepool conditions API (https://github.com/openshift/hypershift/commit/05a7fa17c8156585658b72fa9453a569963ee2bd) in order to check that the tuning has completed and the nodepool is ready, we need to change our check accordingly - check that the condition is false instead of missing. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ffromani commented 4 months ago

/approve /lgtm

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, rbaturov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [ffromani] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 4 months ago

/retest-required

Remaining retests: 0 against base HEAD 4b9ac5204aa237e70519806a19c1000678b2ebc9 and 2 for PR HEAD 35fb96d6db63674df7f7b4c7addef50424ecb1bf in total

openshift-ci[bot] commented 4 months ago

@rbaturov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).