search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

CNF-7123: hypershift: implements missing client calls needed for e2e tests #1107

Closed Tal-or closed 4 months ago

Tal-or commented 4 months ago

This PR has been split from #1084 and is a prerequisite for it. It implements missing API calls that are needed during the e2e tests adjustments

Co-authored-by: Ronny Baturov rbaturov@redhat.com Signed-off-by: Talor Itzhak titzhak@redhat.com

openshift-ci-robot commented 4 months ago

@Tal-or: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1107): >This PR has been split from #1084 and is a prerequisite for it. >It implements missing API calls that are needed during the e2e tests adjustments > >Co-authored-by: Ronny Baturov >Signed-off-by: Talor Itzhak Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Tal-or commented 4 months ago

/hold Depends on https://github.com/openshift/cluster-node-tuning-operator/pull/1100

Tal-or commented 4 months ago

/hold cancel https://github.com/openshift/cluster-node-tuning-operator/pull/1100 got merged

ffromani commented 4 months ago

/approve /lgtm

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [ffromani] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 4 months ago

@Tal-or: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 4 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.17.0-202407111143.p0.gb9d708d.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.