search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

OCPBUGS-38522: Fix the destination of asset's copy #1112

Closed jmencak closed 4 months ago

jmencak commented 4 months ago

1058 introduced an issue, where assets meant to be copied to /usr/local/bin were being copied to /usr/local/bin/bin. Fix this. Additional cleanup (duplicate statements in if/else) to follow.

/cc @jupierce

openshift-ci-robot commented 4 months ago

@jmencak: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1112): >#1058 introduced an issue, where assets meant to be copied to /usr/local/bin were being copied to /usr/local/bin/bin. Fix this. Additional cleanup (duplicate statements in if/else) to follow. > >/cc @jupierce > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [jmencak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jupierce commented 4 months ago

/lgtm

jmencak commented 4 months ago

/test all

jmencak commented 4 months ago

/label acknowledge-critical-fixes-only

openshift-ci[bot] commented 4 months ago

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 4 months ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator This PR has been included in build cluster-node-tuning-operator-container-v4.17.0-202407222110.p0.g10bb4c6.assembly.stream.el9. All builds following this will include this PR.

openshift-ci-robot commented 3 months ago

@jmencak: Jira Issue OCPBUGS-38522: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38522 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1112): >#1058 introduced an issue, where assets meant to be copied to /usr/local/bin were being copied to /usr/local/bin/bin. Fix this. Additional cleanup (duplicate statements in if/else) to follow. > >/cc @jupierce > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jmencak commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@jmencak: Jira Issue OCPBUGS-38522 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1112#issuecomment-2291126634): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jmencak commented 3 months ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 3 months ago

@jmencak: new pull request created: #1134

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1112#issuecomment-2291136171): >/cherry-pick release-4.16 > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.