WIP: enable control of the verbosiness of the operand

[ffromani]

WIP TBD

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [ffromani] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[jmencak]

Thank you for the PR, Francesco.

I can see a couple of disadvantages with this approach.

1) An extra API call to get a config map. 2) Unability to chage verbosity per operand (this would cause a restart of all NTO operands, not just the ones we are interested in).

While the current way of turning on debugging for operands (TuneD) is not ideal, I believe we probably want something along the lines of what we already have:

  recommend:
    operand:
      debug: true

and perhaps add something like:

  recommend:
    operand:
      debug: true
      verbosity: <number>

This might even enable us not to restart the operand/TuneD at all and thus have less impact on the cluster?

[ffromani]

shouldn't we need to change the DaemonSet manifest anyway?

[jmencak]

shouldn't we need to change the DaemonSet manifest anyway?

Why? Wouldn't we just pick up the verbosity from the profile, like we do for debugging? I haven't tried though, so perhaps there are some technical difficulties I'm not seeing.

[ffromani]

ok, sounds fair to me. We'll see in a future PR then.

[jmencak]

ok, sounds fair to me. We'll see in a future PR then.

Let me look into that or whoever gets there first...

[jmencak]

Alternative approach: https://github.com/openshift/cluster-node-tuning-operator/pull/1114