search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

NO-JIRA: makefile: ensure bindata #1116

Closed ffromani closed 4 months ago

ffromani commented 4 months ago

0_config requires now pkg/manifests, so we need to make sure bindata is generated

extracted from #1019 because it helps other PRs too: https://github.com/openshift/cluster-node-tuning-operator/pull/1019#discussion_r1686007433 (xref: #1089)

ffromani commented 4 months ago

/label acknowledge-critical-fixes-only

if CI passes, this change can't break the product

Tal-or commented 4 months ago

/lgtm Thanks

jmencak commented 4 months ago

/approve

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [ffromani,jmencak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ffromani commented 4 months ago 
level=error msg=Attempted to gather ClusterOperator status after installation failure: listing ClusterOperator objects: Get "https://api.ci-op-1dnz5m6r-13bd6.xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx:6443/apis/config.openshift.io/v1/clusteroperators": dial tcp 34.171.110.204:6443: connect: connection refused
ffromani commented 4 months ago

/retest-required

openshift-ci[bot] commented 4 months ago

@ffromani: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 4 months ago

@ffromani: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1116): >0_config requires now `pkg/manifests`, so we need >to make sure bindata is generated > >extracted from #1019 because it helps other PRs too: https://github.com/openshift/cluster-node-tuning-operator/pull/1019#discussion_r1686007433 (xref: #1089) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ffromani commented 4 months ago

/jira refresh

openshift-ci-robot commented 4 months ago

@ffromani: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1116#issuecomment-2242571632): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 4 months ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator This PR has been included in build cluster-node-tuning-operator-container-v4.17.0-202407221413.p0.g18febd2.assembly.stream.el9. All builds following this will include this PR.