search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 104 forks source link

CNF-13391:ppc: adjust for Hypershift #1124

Closed Tal-or closed 3 months ago

Tal-or commented 3 months ago

This PR contains all the necessary changes that are needed to support the creation of PerfomanceProfile for HyperShift platform.

In addition it provides some optimization and coding best-practices which were done along the way

Also we need https://github.com/openshift/must-gather/pull/436 in order to fully complete this task.

Signed-off-by: Talor Itzhak titzhak@redhat.com

openshift-ci-robot commented 3 months ago

@Tal-or: This pull request references CNF-1339 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1124): >WIP Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 months ago

@Tal-or: This pull request references CNF-1339 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1124): >This PR contains all the necessary changes that are needed to support the creation of `PerfomanceProfile` for HyperShift platform. > >In addition it provides some optimization and coding best-practices which were done along the way > >Also we need https://github.com/openshift/must-gather/pull/436 in order to fully complete this task. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 months ago

@Tal-or: This pull request references CNF-1339 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1124): >This PR contains all the necessary changes that are needed to support the creation of `PerfomanceProfile` for HyperShift platform. > >In addition it provides some optimization and coding best-practices which were done along the way > >Also we need https://github.com/openshift/must-gather/pull/436 in order to fully complete this task. > >Signed-off-by: Talor Itzhak Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 months ago

@Tal-or: This pull request references CNF-13391 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1124): >This PR contains all the necessary changes that are needed to support the creation of `PerfomanceProfile` for HyperShift platform. > >In addition it provides some optimization and coding best-practices which were done along the way > >Also we need https://github.com/openshift/must-gather/pull/436 in order to fully complete this task. > >Signed-off-by: Talor Itzhak Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Tal-or commented 3 months ago

/retest

Tal-or commented 3 months ago

/retest

Tal-or commented 3 months ago

/hold I would like to add another test case

Tal-or commented 3 months ago

/hold cancel Test case has been added

yanirq commented 3 months ago

/approve looks ok to me, we can add more tests in a separate PR . Giving others a chance to have another review and ack.

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tal-or, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [yanirq] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 months ago

@Tal-or: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator This PR has been included in build cluster-node-tuning-operator-container-v4.18.0-202408081846.p0.g6d625b5.assembly.stream.el9. All builds following this will include this PR.