search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

OCPBUGS-39320: E2E: Remove checking of reserved cpus in irqbalance file #1140

Closed mrniranjan closed 3 months ago

mrniranjan commented 3 months ago

Remove checking of reserved cpus in the /etc/sysconfig/irqbalance as in the current Performance profile deployment reserved cpus are never added to the irqbalance config file.

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik, mrniranjan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [MarSik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
MarSik commented 3 months ago

/lgtm

mrniranjan commented 3 months ago

/retest-required

Tal-or commented 3 months ago

/test e2e-aws-ovn

Tal-or commented 3 months ago

/retitle NO-JIRA:E2E: Remove checking of reserved cpus in irqbalance file

openshift-ci-robot commented 3 months ago

@mrniranjan: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1140): >Remove checking of reserved cpus in the /etc/sysconfig/irqbalance as in the current Performance profile deployment reserved cpus are never added to the irqbalance config file. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 months ago

/retest-required

Remaining retests: 0 against base HEAD 59487d0da25c70b16e52a28c5f904034981e3eac and 2 for PR HEAD d316583ae7f970239279d74dc81c7f79fae5ac2a in total

MarSik commented 3 months ago

/retest-required

openshift-ci[bot] commented 3 months ago

@mrniranjan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator This PR has been included in build cluster-node-tuning-operator-container-v4.18.0-202408222209.p0.gc2bb893.assembly.stream.el9. All builds following this will include this PR.

MarSik commented 2 months ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 2 months ago

@MarSik: new pull request created: #1148

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1140#issuecomment-2320543956): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
yanirq commented 2 months ago

/retitle OCPBUGS-39320: E2E: Remove checking of reserved cpus in irqbalance file

openshift-ci-robot commented 2 months ago

@mrniranjan: Jira Issue OCPBUGS-39320: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-39320 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1140): >Remove checking of reserved cpus in the /etc/sysconfig/irqbalance as in the current Performance profile deployment reserved cpus are never added to the irqbalance config file. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.