search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

[release-4.17] OCPBUGS-38721: tuned: distinguish deferred updates #1149

Closed yanirq closed 1 month ago

yanirq commented 2 months ago

This is a manual cherry pick of: https://github.com/openshift/cluster-node-tuning-operator/pull/1129 OCPBUGS-28647: tuned: distinguish deferred updates https://github.com/openshift/cluster-node-tuning-operator/pull/1142 OCPBUGS-38795: Fix defer status during recommended profile change https://github.com/openshift/cluster-node-tuning-operator/pull/1162 NO-JIRA: deferred updates: fix in-place update handling on reboot

openshift-ci-robot commented 2 months ago

@yanirq: This pull request references Jira Issue OCPBUGS-38721, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-28647](https://issues.redhat.com//browse/OCPBUGS-28647) is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-28647](https://issues.redhat.com//browse/OCPBUGS-28647) targets the "4.18.0" version, which is one of the valid target versions: 4.18.0 * bug has dependents

Requesting review from QA contact: /cc @mrniranjan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1149): >This is a manual cherry pick of: >https://github.com/openshift/cluster-node-tuning-operator/pull/1129 OCPBUGS-28647: tuned: distinguish deferred updates >https://github.com/openshift/cluster-node-tuning-operator/pull/1142 OCPBUGS-38795: Fix defer status during recommended profile change Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/release-4.17/OWNERS)~~ [yanirq] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yanirq commented 2 months ago

/cc @ffromani @MarSik @jmencak /uncc @kpouget

ffromani commented 2 months ago

/retest

openshift-ci[bot] commented 2 months ago

@yanirq: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jmencak commented 2 months ago

@ffromani considering 4.17.0 wrap up is close , I am wondering whether we should wait with backport-risk-assessed label.

What makes 4.17.0 special vs. 4.17.z? You need backport-risk-assessed for 4.17.z too and customers are more likely wait for 4.17.z than running with 4.17.0 immediately.

yanirq commented 2 months ago

@ffromani considering 4.17.0 wrap up is close , I am wondering whether we should wait with backport-risk-assessed label.

What makes 4.17.0 special vs. 4.17.z? You need backport-risk-assessed for 4.17.z too and customers are more likely wait for 4.17.z than running with 4.17.0 immediately.

Yes you are right. scratch the version reference.

ffromani commented 1 month ago

/lgtm

jmencak commented 1 month ago

/label backport-risk-assessed

ffromani commented 1 month ago

we need staff-eng-approved anyway, so I guess we will end up delivering in 4.17.z

jmencak commented 1 month ago

@liqcui , can we please have cherry-pick-approved label for this? Thank you!

liqcui commented 1 month ago

/label cherry-pick-approved

openshift-ci-robot commented 1 month ago

@yanirq: Jira Issue OCPBUGS-38721: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38721 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1149): >This is a manual cherry pick of: >https://github.com/openshift/cluster-node-tuning-operator/pull/1129 OCPBUGS-28647: tuned: distinguish deferred updates >https://github.com/openshift/cluster-node-tuning-operator/pull/1142 OCPBUGS-38795: Fix defer status during recommended profile change >https://github.com/openshift/cluster-node-tuning-operator/pull/1162 NO-JIRA: deferred updates: fix in-place update handling on reboot Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator This PR has been included in build cluster-node-tuning-operator-container-v4.17.0-202410022234.p0.gc77c557.assembly.stream.el9. All builds following this will include this PR.