search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

NO-JIRA: Remove upstream TuneD patch #1151

Closed jmencak closed 1 month ago

jmencak commented 2 months ago

Remove 030-no-bootloader-errors.diff. Any TuneD patch that is not upstream is a bad idea/temporary fix. Also, none of the patches in NTO repository are shipped officially with OCP and their presence can be misleading to contributors. The functionality provided by the patch can be worked around by configuring TuneD in the [bootloader] section.

Other changes:

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [jmencak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jmencak commented 2 months ago

@MarSik / @rbaturov any thoughs on this PR? Thank you.

MarSik commented 1 month ago

/lgtm

openshift-ci-robot commented 1 month ago

@jmencak: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1151): >Remove `030-no-bootloader-errors.diff`. Any TuneD patch that is not upstream is a bad idea/temporary fix. Also, none of the patches in NTO repository are shipped officially with OCP and their presence can be misleading to contributors. The functionality provided by the patch can be worked around by configuring TuneD in the `[bootloader]` section. > >Other changes: > * Simplify switchTunedHome as suggested by a reviewer in an earlier review. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator This PR has been included in build cluster-node-tuning-operator-container-v4.18.0-202410172112.p0.g1cffedb.assembly.stream.el9. All builds following this will include this PR.