search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 104 forks source link

OCPBUGS-41487: E2E: Add hypershift support to workloadhints testsuite #1154

Open mrniranjan opened 2 months ago

mrniranjan commented 2 months ago
mrniranjan commented 1 month ago

/test e2e-upgrade

openshift-ci-robot commented 1 month ago

@mrniranjan: This pull request references Jira Issue OCPBUGS-41487, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @mrniranjan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1154): >- Changes primarily done to check nodepools instead of mcp for hypershift. >- replace dataplane test client instead of generic testclient.Client Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: mrniranjan.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1154#issuecomment-2336764300): >@mrniranjan: This pull request references [Jira Issue OCPBUGS-41487](https://issues.redhat.com//browse/OCPBUGS-41487), which is valid. The bug has been moved to the POST state. > >
3 validation(s) were run on this bug > >* bug is open, matching expected state (open) >* bug target version (4.18.0) matches configured target version for branch (4.18.0) >* bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @mrniranjan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1154): >- Changes primarily done to check nodepools instead of mcp for hypershift. >- replace dataplane test client instead of generic testclient.Client Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Tal-or commented 1 month ago

@mrniranjan Please add the suite to the make target, because currently it's not running.

mrniranjan commented 1 month ago

/retest-required

Tal-or commented 4 weeks ago

/lgtm

Thanks!

shajmakh commented 1 week ago

/approve

MarSik commented 1 week ago

/approved

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik, mrniranjan, shajmakh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [MarSik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 6d2e1edef5b898f63617b1cdba589b3083b87331 and 2 for PR HEAD f16d3d727d007174db9786e85bdad86e9c28de5f in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 6d2e1edef5b898f63617b1cdba589b3083b87331 and 2 for PR HEAD f16d3d727d007174db9786e85bdad86e9c28de5f in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 6d2e1edef5b898f63617b1cdba589b3083b87331 and 2 for PR HEAD f16d3d727d007174db9786e85bdad86e9c28de5f in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 2e07e3ab309a29dbf4a147c76869291e8fb1e350 and 2 for PR HEAD f16d3d727d007174db9786e85bdad86e9c28de5f in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD 2e07e3ab309a29dbf4a147c76869291e8fb1e350 and 2 for PR HEAD f16d3d727d007174db9786e85bdad86e9c28de5f in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD a98b16a6c6d9e1f0fc575fba137d0ffd22178f0b and 2 for PR HEAD f16d3d727d007174db9786e85bdad86e9c28de5f in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD a98b16a6c6d9e1f0fc575fba137d0ffd22178f0b and 2 for PR HEAD f16d3d727d007174db9786e85bdad86e9c28de5f in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD a98b16a6c6d9e1f0fc575fba137d0ffd22178f0b and 2 for PR HEAD f16d3d727d007174db9786e85bdad86e9c28de5f in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD a98b16a6c6d9e1f0fc575fba137d0ffd22178f0b and 2 for PR HEAD f16d3d727d007174db9786e85bdad86e9c28de5f in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD a98b16a6c6d9e1f0fc575fba137d0ffd22178f0b and 2 for PR HEAD f16d3d727d007174db9786e85bdad86e9c28de5f in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD a98b16a6c6d9e1f0fc575fba137d0ffd22178f0b and 2 for PR HEAD f16d3d727d007174db9786e85bdad86e9c28de5f in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD a98b16a6c6d9e1f0fc575fba137d0ffd22178f0b and 2 for PR HEAD f16d3d727d007174db9786e85bdad86e9c28de5f in total

Tal-or commented 1 week ago

Seems like actual failure

  > Enter [BeforeEach] [rfe_id:49062][workloadHints] Telco friendly workload specific PerformanceProfile API - /go/src/github.com/openshift/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/8_performance_workloadhints/workloadhints.go:61 @ 10/27/24 11:59:26.333
I1027 11:59:26.358328   20478 workloadhints.go:859] updated nodes from map[string]string{"node-role.kubernetes.io/worker-cnf":""}: []
I1027 11:59:26.358350   20478 workloadhints.go:861] updated nodes matching optional selector: []
  [FAILED] cannot find RT enabled worker nodes
  Expected
      <[]v1.Node | len:0, cap:0>: nil
  not to be empty
  In [BeforeEach] at: /go/src/github.com/openshift/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/8_performance_workloadhints/workloadhints.go:863 @ 10/27/24 11:59:2
openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD a98b16a6c6d9e1f0fc575fba137d0ffd22178f0b and 2 for PR HEAD f16d3d727d007174db9786e85bdad86e9c28de5f in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD bc3ecaea5131f120ef8a282039c3ffd013cb8a76 and 1 for PR HEAD f16d3d727d007174db9786e85bdad86e9c28de5f in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD bc3ecaea5131f120ef8a282039c3ffd013cb8a76 and 2 for PR HEAD f16d3d727d007174db9786e85bdad86e9c28de5f in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD bc3ecaea5131f120ef8a282039c3ffd013cb8a76 and 2 for PR HEAD f16d3d727d007174db9786e85bdad86e9c28de5f in total

openshift-ci-robot commented 1 week ago

/retest-required

Remaining retests: 0 against base HEAD bc3ecaea5131f120ef8a282039c3ffd013cb8a76 and 2 for PR HEAD f16d3d727d007174db9786e85bdad86e9c28de5f in total

mrniranjan commented 1 week ago

/hold

openshift-ci[bot] commented 1 week ago

New changes are detected. LGTM label has been removed.

mrniranjan commented 1 week ago 
  STEP: Waiting for TuneD to start on nodes - /go/src/github.com/openshift/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/8_performance_workloadhints/workloadhints.go:123 @ 10/30/24 10:52:22.36
  [FAILED] Unexpected error:
      <*errors.errorString | 0xc000223300>: 
      failed to find a TuneD Pod for node ip-10-0-142-236.ec2.internal
      {
          s: "failed to find a TuneD Pod for node ip-10-0-142-236.ec2.internal",
      }
  occurred
  In [It] at: /go/src/github.com/openshift/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/8_performance_workloadhints/workloadhints.go:132 @ 10/30/24 10:57:22.476

@Tal-or why doesn't the tuned pod start on the HCP nodes ?, when i execute the tests locally i see tuned pod running and tests proceed

mrniranjan commented 1 day ago

/test e2e-hypershift-pao

openshift-ci[bot] commented 1 day ago

@mrniranjan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift-pao 1a8d236c864a677a4d23247f15aa598e060a8c92 link true /test e2e-hypershift-pao

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).