search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
99 stars 104 forks source link

OCPBUGS-38900: Drop sched_migration_cost_ns setting #1163

Open jmencak opened 1 week ago

jmencak commented 1 week ago

When using a PerformanceProfile, a TuneD scheduler was setting sched_migration_cost_ns. This setting was previously used by throughput-performance and latency-performance profiles. However, it was dropped from these profiles based on performance evaluation for RHEL-9 as discussed in rhbz#1957829.

Setting sched_migration_cost_ns causes issues when SecureBoot/kernel_lockdown is in effect. Do not set this tunable when using PerformanceProfiles.

Resolves: OCPBUGS-38900

openshift-ci-robot commented 1 week ago

@jmencak: This pull request references Jira Issue OCPBUGS-38900, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1163): >When using a PerformanceProfile, a TuneD scheduler was setting sched_migration_cost_ns. This setting was previously used by throughput-performance and latency-performance profiles. However, it was dropped from these profiles based on performance evaluation for RHEL-9 as discussed in rhbz#1957829. > >Setting sched_migration_cost_ns causes issues when SecureBoot/kernel_lockdown is in effect. Do not set this tunable when using PerformanceProfiles. > >Resolves: OCPBUGS-38900 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [jmencak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jmencak commented 6 days ago

/retest

jmencak commented 5 days ago

/retest

yanirq commented 3 days ago

/retest

openshift-ci[bot] commented 2 days ago

@jmencak: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-pao 7e7a20087f7d2bb18e37b9695fad94d961f38d66 link true /test e2e-gcp-pao
ci/prow/e2e-hypershift-pao 7e7a20087f7d2bb18e37b9695fad94d961f38d66 link true /test e2e-hypershift-pao

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).