search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

WIP: amend irqbalance tests to check IRQBALANCE_BANNED_CPUS #1165

Open yanirq opened 2 months ago

yanirq commented 2 months ago

Use IRQBALANCE_BANNED_CPULIST instead of the deprecated IRQBALANCE_BANNED_CPUS in irqbalance tests to match tuned irqbalance plugin

xref: https://github.com/redhat-performance/tuned/pull/657/commits/7825b1133039f370e0863a0f824e842e237e4123

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [yanirq] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jmencak commented 2 months ago

/cc jmencak

jmencak commented 2 months ago

If we do this change, will this not break the potential TuneD https://github.com/redhat-performance/tuned/pull/657 revert?

yanirq commented 2 months ago

If we do this change, will this not break the potential TuneD redhat-performance/tuned#657 revert?

it will, currently setting this as WIP. I might add a more modular option to check for both values if required

openshift-ci[bot] commented 2 months ago

@yanirq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-pao eae70fcc4d20026c57e0cfa37081107bbf1bf091 link true /test e2e-gcp-pao
ci/prow/e2e-hypershift-pao eae70fcc4d20026c57e0cfa37081107bbf1bf091 link true /test e2e-hypershift-pao

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).