search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

OCPBUGS-43875: Fix context deadlines in ExecCommandOnPod() #1174

Closed jmencak closed 1 month ago

jmencak commented 1 month ago

During testing on x86_64 cluster from an arm64 host, I've observed strange context deadlines when enabling stdin in ExecCommandOnPod() function.

Disable stdin as it is not needed during non-interactive tests.

Other changes:

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [jmencak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jmencak commented 1 month ago

/retest

openshift-ci-robot commented 1 month ago

@jmencak: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1174): >During testing on x86_64 cluster from an arm64 host, I've >observed strange context deadlines when enabling stdin in >ExecCommandOnPod() function. > >Disable stdin as it is not needed during non-interactive tests. > >Other changes: > * Drop obsolete test "test_id:32375". > * Drop unnecessary "/bin/bash -c" in some tests. > Further cleanup possible, but it could make code > slightly less readable, so avoiding it for now. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Tal-or commented 1 month ago

/lgtm Thank you for figure this out

openshift-ci[bot] commented 1 month ago

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator This PR has been included in build cluster-node-tuning-operator-container-v4.18.0-202409291752.p0.g86e5d63.assembly.stream.el9. All builds following this will include this PR.

jmencak commented 1 month ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 1 month ago

@jmencak: new pull request created: #1189

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1174#issuecomment-2423571374): >/cherry-pick release-4.17 > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 3 weeks ago

@jmencak: Jira Issue OCPBUGS-43875: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43875 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1174): >During testing on x86_64 cluster from an arm64 host, I've >observed strange context deadlines when enabling stdin in >ExecCommandOnPod() function. > >Disable stdin as it is not needed during non-interactive tests. > >Other changes: > * Drop obsolete test "test_id:32375". > * Drop unnecessary "/bin/bash -c" in some tests. > Further cleanup possible, but it could make code > slightly less readable, so avoiding it for now. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.