openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

OCPBUGS-42567: Add cluster-wide proxy env file #1176

Closed jmencak closed 1 month ago

jmencak commented 1 month ago

This is a manual backport of https://github.com/openshift/cluster-node-tuning-operator/pull/1171

Add cluster-wide proxy environment file /etc/mco/proxy.env to ocp-tuned-one-shot.service file. This allows podman to pull NTO image in environments which need to use http(s) proxy for out-of-cluster connections.

Resolves: OCPBUGS-42567

openshift-ci-robot commented 1 month ago

@jmencak: This pull request references Jira Issue OCPBUGS-42567, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1176): >This is a manual backport of https://github.com/openshift/cluster-node-tuning-operator/pull/1171 > >Add cluster-wide proxy environment file /etc/mco/proxy.env to ocp-tuned-one-shot.service file. This allows podman to pull NTO image in environments which need to use http(s) proxy for out-of-cluster connections. > >Resolves: OCPBUGS-42567 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/release-4.14/OWNERS)~~ [jmencak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jmencak commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jmencak commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@jmencak: This pull request references Jira Issue OCPBUGS-42567, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.z) matches configured target version for branch (4.14.z) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-42284](https://issues.redhat.com//browse/OCPBUGS-42284) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-42284](https://issues.redhat.com//browse/OCPBUGS-42284) targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1176#issuecomment-2392941365): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jmencak commented 1 month ago

/label backport-risk-assessed

ffromani commented 1 month ago

/lgtm

jmencak commented 1 month ago

@liqcui , could we please have cherry-pick-approved label for this? Thank you!

MarSik commented 1 month ago

/lgtm

liqcui commented 1 month ago

/label cherry-pick-approved

openshift-ci-robot commented 1 month ago

@jmencak: Jira Issue OCPBUGS-42567: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42567 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1176): >This is a manual backport of https://github.com/openshift/cluster-node-tuning-operator/pull/1171 > >Add cluster-wide proxy environment file /etc/mco/proxy.env to ocp-tuned-one-shot.service file. This allows podman to pull NTO image in environments which need to use http(s) proxy for out-of-cluster connections. > >Resolves: OCPBUGS-42567 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator This PR has been included in build cluster-node-tuning-operator-container-v4.14.0-202410041338.p0.g099cc7b.assembly.stream.el9. All builds following this will include this PR.

openshift-merge-robot commented 1 month ago

Fix included in accepted release 4.14.0-0.nightly-2024-10-04-174104