search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

CNF-14628: e2e: Adjust profile nodeSeletcor on hypershift #1183

Closed rbaturov closed 3 weeks ago

rbaturov commented 1 month ago

In this PR we are introducing several changes for hypershift platform testing: A test profile that will be deployed will no longer use the node-role.kubernetes.io/worker-cnf= label. Instead, it will use the node-role.kubernetes.io/worker= label. We are no longer relabeling the worker nodes post-tuning. More info is described in the commits.

openshift-ci-robot commented 1 month ago

@rbaturov: This pull request references CNF-14628 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1183): >In this PR we are introducing a change for **hypershift** platform testing: >A test profile that will be deployed will no longer use the `node-role.kubernetes.io/worker-cnf=` label. Instead, it will use the `node-role.kubernetes.io/worker=` label. >More info is described in the commits. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci-robot commented 1 month ago

@rbaturov: This pull request references CNF-14628 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1183): >In this PR we are introducing several changes for **hypershift** platform testing: >A test profile that will be deployed will no longer use the `node-role.kubernetes.io/worker-cnf=` label. Instead, it will use the `node-role.kubernetes.io/worker=` label. >We are no longer relabeling the worker nodes post-tuning. >More info is described in the commits. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rbaturov commented 1 month ago

/test all

ffromani commented 1 month ago

sigh, you will need a non-trivial rebase because the commits you depend on have been squashed. Please do that rebase ASAP.

rbaturov commented 1 month ago

sigh, you will need a non-trivial rebase because the commits you depend on have been squashed. Please do that rebase ASAP.

Where they were squashed? #1182 has all the 5 commits this depends on When #1182 will be merged I'll rebase on top of master

ffromani commented 1 month ago

sigh, you will need a non-trivial rebase because the commits you depend on have been squashed. Please do that rebase ASAP.

Where they were squashed? #1182 has all the 5 commits this depends on When #1182 will be merged I'll rebase on top of master

My mistake, I mixed up PRs, scratch my comment and let's move on

ffromani commented 1 month ago

/approve we want this fix

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, rbaturov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [ffromani] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rbaturov commented 1 month ago

/retest-required

rbaturov commented 1 month ago

/retest-required

Tal-or commented 3 weeks ago

/lgtm /hold cancel

Thank you for figure it out

openshift-ci-robot commented 3 weeks ago

/retest-required

Remaining retests: 0 against base HEAD a98b16a6c6d9e1f0fc575fba137d0ffd22178f0b and 2 for PR HEAD f5298bfb2f41a2fb32792d0a94af61e7f04bf5fa in total

yanirq commented 3 weeks ago

/retest

openshift-ci[bot] commented 3 weeks ago

@rbaturov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator This PR has been included in build cluster-node-tuning-operator-container-v4.18.0-202410280439.p0.gbc3ecae.assembly.stream.el9. All builds following this will include this PR.