OCPBUGS-43832: E2E: Add tests to support NTO over hypershift with multi nodepools.

[SargunNarula]

• Added tests for Multiple Performance Profile under different nodepools
• Adjusted nodepool utility to handle multiple nodepool
• Added test suite run in makefile

[openshift-ci-robot]

@SargunNarula: This pull request references Jira Issue OCPBUGS-43832, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (snarula@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1184): >- Added tests for Multiple Performance Profile under different nodepools >- Adjusted nodepool utility to handle multiple nodepool >- Added test suite run in makefile Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[Tal-or]

Where do we create additional nodePool? I don't see it.

[SargunNarula]

Where do we create additional nodePool? I don't see it.

I'm deploying the additional nodepool using kcli, while cluster installation in my test environment. There is an alternative method using hypershift with the command hypershift create nodepool --cluster-name . However, I don't believe it's appropriate to include commands that modify the cluster structure within a test. There is a way to add via applying a manifest - Link

But i think the arch details are beyond the scope of this test, What do you suggest?

[mrniranjan]

Where do we create additional nodePool? I don't see it.

Creation of nodepool and adding hosts under nodepool is an infrastructure thing, Currently this is not possible in upstream CI, We need to skip these tests and execute these tests only in downstream

[SargunNarula]

/retest

[Tal-or]

Where do we create additional nodePool? I don't see it.

Creation of nodepool and adding hosts under nodepool is an infrastructure thing, Currently this is not possible in upstream CI, We need to skip these tests and execute these tests only in downstream

I agree. these kind of tests need to be running on the d/s and skipped u/s

[Tal-or]

    [test_id:75077] should verify support for different performance profiles on hosted cluster via multiple node pools
    /go/src/github.com/openshift/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/12_hypershift/hypershift.go:87
  > Enter [BeforeAll] Multiple performance profile in hypershift - /go/src/github.com/openshift/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/12_hypershift/hypershift.go:43 @ 11/15/24 08:59:13.066
  STEP: Checking if discovery mode is enabled and performance profile is not found - /go/src/github.com/openshift/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/12_hypershift/hypershift.go:44 @ 11/15/24 08:59:13.067
  Nov 15 08:59:13.067: [INFO]: Node label: map[node-role.kubernetes.io/worker:]
  [FAILED] Expected
      <int>: 1
  to be >=
      <int>: 2

Probably this should be skipped u/s because we only have a single nodepool

[SargunNarula]

/retest

[Tal-or]

Thanks /lgtm

[SargunNarula]

/retest

[Tal-or]

/lgtm /acknowledge-critical-fixes-only

[Tal-or]

/label acknowledge-critical-fixes-only Tests code, not part of OCP payload

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik, SargunNarula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [MarSik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[SargunNarula]

/retest

[SargunNarula]

/retest

[Tal-or]

/lgtm

[openshift-ci[bot]]

@SargunNarula: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[openshift-ci-robot]

@SargunNarula: Jira Issue OCPBUGS-43832: All pull requests linked via external trackers have merged:

• openshift/cluster-node-tuning-operator#1184

Jira Issue OCPBUGS-43832 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1184): >- Added tests for Multiple Performance Profile under different nodepools >- Adjusted nodepool utility to handle multiple nodepool >- Added test suite run in makefile Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator This PR has been included in build cluster-node-tuning-operator-container-v4.19.0-202411211638.p0.gbe3fc39.assembly.stream.el9. All builds following this will include this PR.