search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

OCPBUGS-43944: E2E: fix modify node selector to use lowercase #1185

Closed mrniranjan closed 1 month ago

mrniranjan commented 1 month ago

When using uppercase characters in node selector field of Performance profile causes validator to complain about RFC-1123 compliance

Change to lower case characters for node selector map

openshift-ci-robot commented 1 month ago

@mrniranjan: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1185): >When using uppercase characters in node selector field of Performance profile causes validator to >complain about RFC-1123 compliance > >Change to lower case characters for node selector map Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

@mrniranjan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
MarSik commented 1 month ago

/lgtm /approved

MarSik commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik, mrniranjan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [MarSik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
MarSik commented 1 month ago

/cherry-pick release-4.17 release-4.16

openshift-cherrypick-robot commented 1 month ago

@MarSik: new pull request created: #1186

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1185#issuecomment-2422315207): >/cherry-pick release-4.17 release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator This PR has been included in build cluster-node-tuning-operator-container-v4.18.0-202410181340.p0.ge3ba0a9.assembly.stream.el9. All builds following this will include this PR.

openshift-ci-robot commented 3 weeks ago

@mrniranjan: Jira Issue OCPBUGS-43944: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43944 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1185): >When using uppercase characters in node selector field of Performance profile causes validator to >complain about RFC-1123 compliance > >Change to lower case characters for node selector map Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.