search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

[release-4.17] OCPBUGS-43551: Make ocp-tuned-one-shot.service restart on-failure #1187

Closed openshift-cherrypick-robot closed 3 weeks ago

openshift-cherrypick-robot commented 1 month ago

This is an automated cherry-pick of #1177

/assign jmencak

openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-42492 has been cloned as Jira Issue OCPBUGS-43551. Will retitle bug to link to clone. /retitle [release-4.17] OCPBUGS-43551: Make ocp-tuned-one-shot.service restart on-failure

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1187): >This is an automated cherry-pick of #1177 > >/assign jmencak Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-43551, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1187): >This is an automated cherry-pick of #1177 > >/assign jmencak Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jmencak commented 1 month ago

/retest

jmencak commented 1 month ago

Needs https://github.com/openshift/cluster-node-tuning-operator/pull/1188 merged to pass the CI.

yanirq commented 3 weeks ago

/approve /label backport-risk-assessed

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/release-4.17/OWNERS)~~ [yanirq] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yanirq commented 3 weeks ago

/retest

yanirq commented 3 weeks ago

/lgtm

jmencak commented 3 weeks ago

/cc @liqcui We need https://issues.redhat.com//browse/OCPBUGS-42492 VERIFIED to backport this. After that, can we please have cherry-pick-approved label, Liquan? Thank you.

jmencak commented 3 weeks ago

/jira refresh

openshift-ci-robot commented 3 weeks ago

@jmencak: This pull request references Jira Issue OCPBUGS-43551, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.z) matches configured target version for branch (4.17.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-42492](https://issues.redhat.com//browse/OCPBUGS-42492) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-42492](https://issues.redhat.com//browse/OCPBUGS-42492) targets the "4.18.0" version, which is one of the valid target versions: 4.18.0 * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1187#issuecomment-2446864459): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
liqcui commented 3 weeks ago

/label cherry-pick-approved

openshift-ci-robot commented 3 weeks ago

/retest-required

Remaining retests: 0 against base HEAD d2e1407af7dbfb2ca9e2539f371ed0c6069b356b and 2 for PR HEAD ba4772b3e8a3663639b61150dc80355d8382f4a7 in total

openshift-ci[bot] commented 3 weeks ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 3 weeks ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-43551: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43551 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1187): >This is an automated cherry-pick of #1177 > >/assign jmencak Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator This PR has been included in build cluster-node-tuning-operator-container-v4.17.0-202410311235.p0.g4963e7b.assembly.stream.el9. All builds following this will include this PR.

jmencak commented 3 weeks ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 3 weeks ago

@jmencak: new pull request created: #1202

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1187#issuecomment-2450032165): >/cherry-pick release-4.16 > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.