openshift-ci-robot
commented
1 month ago @MarSik: This pull request references CNF-14090 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.18" instead.
In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1191):
>* [CNF-14090](https://issues.redhat.com//browse/CNF-14090): Add vendor and architecture specific tuning options
>- Performance tuning support for 3 platforms (amd/x86,arm/aarch64,intel/x86) is added in this change
>- When a valid platform is detected the additional platform specific tuning will be imported alongside the default tuning
>- This makes use of a new helper function added to tuned to detect the system name and architecture
>- Update unit tests to account for the various changes
>- Add new unit tests to cover the platform specific tuning
>
>* [CNF-14090](https://issues.redhat.com//browse/CNF-14090): Re-sync e2e test yaml for tuning changes
>
>* [CNF-14090](https://issues.redhat.com//browse/CNF-14090): Use variable composition for idle_poll
>- idle=poll is only supported on x86
>- Update tests to account for changes
>- Add explaination comments to empty values in openshift-node-performance
>
>* [CNF-14090](https://issues.redhat.com//browse/CNF-14090): Re-sync e2e test yaml for tuning changes
>
>* [CNF-14090](https://issues.redhat.com//browse/CNF-14090): Fix active/passive pstates
>
>* [CNF-14090](https://issues.redhat.com//browse/CNF-14090): Re-sync e2e test yaml for tuning changes
Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot]
MarSik
bartwensley
fontivan
CNF-14090: Add vendor and architecture specific tuning options
Performance tuning support for 3 platforms (amd/x86,arm/aarch64,intel/x86) is added in this change
When a valid platform is detected the additional platform specific tuning will be imported alongside the default tuning
This makes use of a new helper function added to tuned to detect the system name and architecture
Update unit tests to account for the various changes
Add new unit tests to cover the platform specific tuning
CNF-14090: Re-sync e2e test yaml for tuning changes
CNF-14090: Use variable composition for idle_poll
idle=poll is only supported on x86
Update tests to account for changes
Add explaination comments to empty values in openshift-node-performance
CNF-14090: Re-sync e2e test yaml for tuning changes
CNF-14090: Fix active/passive pstates
CNF-14090: Re-sync e2e test yaml for tuning changes
OCPBUGS-43665: Drop amd_iommu=on from amd tuning
"=on" is not a valid value for amd_iommu
amd_iommu is enabled by default unless you specify "amd_iommu=off", unlike intel
See kernel docs for more information (https://docs.kernel.org/admin-guide/kernel-parameters.html)
OCPBUGS-43666: Fix kernel arguments ordering on Intel
An upgrade from previous version causes one extra reboot due to differently ordered kernel arguments. This is a side effect of platform specific tuned profile split we merged in https://github.com/openshift/cluster-node-tuning-operator/pull/1083
This fix updates the Intel specific tuned profile to follow the same ordering that was used in the past.
It does so by exploiting a specific tuned behavior of the bootloader plugin. It orders the kernel argument cmdline_suffix keys based on the order of first appearance. Any additional appearance just changes the value, but not the ordering.
The change is only needed for Intel, because we have never supported other platforms before and so upgrade is not an issue.