search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

OCPBUGS-43842: e2e: performance: verify tuned one-shot service vs kubelet #1192

Closed openshift-cherrypick-robot closed 4 weeks ago

openshift-cherrypick-robot commented 1 month ago

This is an automated cherry-pick of #1106

/assign shajmakh

shajmakh commented 1 month ago

the fix was backported to 4.14, do the same for the test cc @jmencak

shajmakh commented 1 month ago

/lgtm /backport-risk-assessed

shajmakh commented 1 month ago

no risk in this test backport /label backport-risk-assessed

openshift-ci[bot] commented 1 month ago

@shajmakh: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers]

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1192#issuecomment-2429275884): >no risk in this test backport >/label backport-risk-assessed Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
shajmakh commented 1 month ago

/cherry-pick release-4.15

openshift-cherrypick-robot commented 1 month ago

@shajmakh: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1192#issuecomment-2429301424): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jmencak commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/release-4.16/OWNERS)~~ [jmencak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
shajmakh commented 4 weeks ago

/retest /label cherry-pick-approved the bug was already fixed & verified on 4.16: https://issues.redhat.com/browse/OCPBUGS-26401

jmencak commented 4 weeks ago

/label backport-risk-assessed

jmencak commented 4 weeks ago

Hopefully this will help with the valid Jira label /retitle OCPBUGS-26401: e2e: performance: verify tuned one-shot service vs kubelet

openshift-ci-robot commented 4 weeks ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-26401, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1192): >This is an automated cherry-pick of #1106 > >/assign shajmakh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jmencak commented 4 weeks ago

/jira refresh

openshift-ci-robot commented 4 weeks ago

@jmencak: This pull request references Jira Issue OCPBUGS-26401, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1192#issuecomment-2437348346): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jmencak commented 4 weeks ago

@shajmakh if you want to merge this, we need a valid BZ label. Either we can ask a staff engineer for this or you want a dependent bug verified for 4.17 (and also likely 4.18 not sure). Leaving a decision up to you. It is a lot of admin just to add an e2e test at this stage.

shajmakh commented 4 weeks ago

/retitle OCPBUGS-43842: e2e: performance: verify tuned one-shot service vs kubelet /jira refresh

openshift-ci-robot commented 4 weeks ago

@shajmakh: This pull request references Jira Issue OCPBUGS-26401, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1192#issuecomment-2437717719): >/retitle OCPBUGS-43842: e2e: performance: verify tuned one-shot service vs kubelet >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 4 weeks ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-43842, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1192): >This is an automated cherry-pick of #1106 > >/assign shajmakh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
shajmakh commented 4 weeks ago

/jira refresh

openshift-ci-robot commented 4 weeks ago

@shajmakh: This pull request references Jira Issue OCPBUGS-43842, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-43841](https://issues.redhat.com//browse/OCPBUGS-43841) is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-43841](https://issues.redhat.com//browse/OCPBUGS-43841) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0, 4.17.z * bug has dependents

Requesting review from QA contact: /cc @shajmakh

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1192#issuecomment-2437721921): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
shajmakh commented 4 weeks ago

/retest

openshift-ci[bot] commented 4 weeks ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 4 weeks ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-43842: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43842 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1192): >This is an automated cherry-pick of #1106 > >/assign shajmakh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 4 weeks ago

@shajmakh: #1192 failed to apply on top of branch "release-4.15":

Applying: e2e: performance: verify tuned one-shot service vs kubelet
Using index info to reconstruct a base tree...
M   test/e2e/performanceprofile/functests/1_performance/performance.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/performanceprofile/functests/1_performance/performance.go
CONFLICT (content): Merge conflict in test/e2e/performanceprofile/functests/1_performance/performance.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 e2e: performance: verify tuned one-shot service vs kubelet
In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1192#issuecomment-2429301424): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 4 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202410251707.p0.g884858e.assembly.stream.el9. All builds following this will include this PR.