search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

CNF-13014: Check for tuned patches before attempting to apply them in the dockerfile script #1193

Closed fontivan closed 1 month ago

fontivan commented 1 month ago 
- If the directory does not exist or does not contain any patches we should not attempt to patch anything
- Resolves build failure when using the script (locally and in CI)
openshift-ci-robot commented 1 month ago

@fontivan: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1193): >- There are no more upstream tuned patches since PR #1151, so this is no longer necessary Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
fontivan commented 1 month ago

/cc @jmencak

fontivan commented 1 month ago

/cc @MarSik

openshift-ci-robot commented 1 month ago

@fontivan: This pull request references CNF-13014 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1193): >- There are no more upstream tuned patches since PR #1151, so this is no longer necessary Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@fontivan: This pull request references CNF-13014 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1193): >- There are no more upstream tuned patches since PR #1151, so this is no longer necessary >- Resolves build failure when using the script (locally and in CI) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@fontivan: This pull request references CNF-13014 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1193): > - If the directory does not exist or does not contain any patches we should not attempt to patch anything > - Resolves build failure when using the script (locally and in CI) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

@fontivan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jmencak commented 1 month ago

/approve /lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fontivan, jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [jmencak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator This PR has been included in build cluster-node-tuning-operator-container-v4.18.0-202410230712.p0.ga5b95d2.assembly.stream.el9. All builds following this will include this PR.