search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

PSAP-1567: Bump the latest k8s and OpenShift dependencies #1195

Closed jmencak closed 1 month ago

jmencak commented 1 month ago

Notable changes:

openshift-ci-robot commented 1 month ago

@jmencak: This pull request references PSAP-1567 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1195): >Notable changes: > * Removed most pinned dependencies. > * Updated PPC code to work with the latest sigs.k8s.io/controller-runtime v0.19.0 as its low-level API changed. > * Updated main.go to use new caching options. > * Switched from "github.com/openshift/kubernetes-sigs-controller-tools" controller-gen to "sigs.k8s.io/controller-tools/cmd/controller-gen". Even the latest upstream openshift's controller-gen (and all others including v0.9.2) were failing during CRD generation with: unable to locate schema for type "k8s.io/api/core/v1".ConditionStatus. That issue was fixed in "github.com/openshift/kubernetes-sigs-controller-tools", see https://github.com/kubernetes-sigs/controller-tools/issues/324 > * Fixed performanceprofile_types.go for v1alpha1 to generate API deepcopy objects. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [jmencak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ffromani commented 1 month ago

/lgtm

with such a large change, we can only trust CI

jmencak commented 1 month ago

Grrr, forgot to run the linter. :/

openshift-ci[bot] commented 1 month ago

@jmencak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lint f9aec69dd6d93a41e0872eca429e4c468e93d180 link false /test lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jmencak commented 1 month ago

Hmm, it looks like the linter is optional. We should really change this. Follow-up PR to fix the linter.

jmencak commented 1 month ago

PR to enforce the linter

openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator This PR has been included in build cluster-node-tuning-operator-container-v4.18.0-202410231410.p0.g6bab18e.assembly.stream.el9. All builds following this will include this PR.

xueqzhan commented 1 month ago

/payload-job periodic-ci-openshift-release-master-nightly-4.18-fips-payload-scan

openshift-ci[bot] commented 1 month ago

@xueqzhan: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5ba821f0-9202-11ef-9ea1-c035d89ad5c4-0