search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

OCPBUGS-44275: Drop sched_migration_cost_ns setting #1207

Closed jmencak closed 1 week ago

jmencak commented 2 weeks ago

This is a manual backport of #1203.

When using a PerformanceProfile, a TuneD scheduler was setting sched_migration_cost_ns. This setting was previously used by throughput-performance and latency-performance profiles. However, it was dropped from these profiles based on performance evaluation for RHEL-9 as discussed in rhbz#1957829.

Setting sched_migration_cost_ns causes issues when SecureBoot/kernel_lockdown is in effect. Do not set this tunable when using PerformanceProfiles.

Resolves: OCPBUGS-44275

openshift-ci-robot commented 2 weeks ago

@jmencak: This pull request references Jira Issue OCPBUGS-44275, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1207): >This is a manual backport of #1203. > >When using a PerformanceProfile, a TuneD scheduler was setting sched_migration_cost_ns. This setting was previously used by throughput-performance and latency-performance profiles. However, it was dropped from these profiles based on performance evaluation for RHEL-9 as discussed in rhbz#1957829. > >Setting sched_migration_cost_ns causes issues when SecureBoot/kernel_lockdown is in effect. Do not set this tunable when using PerformanceProfiles. > >Resolves: OCPBUGS-44275 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jmencak commented 2 weeks ago

/retest

jmencak commented 2 weeks ago

/label backport-risk-assessed

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/release-4.15/OWNERS)~~ [MarSik,jmencak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ffromani commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@ffromani: This pull request references Jira Issue OCPBUGS-44275, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1207#issuecomment-2461996790): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jmencak commented 1 week ago

/jira refresh

openshift-ci-robot commented 1 week ago

@jmencak: This pull request references Jira Issue OCPBUGS-44275, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.z) matches configured target version for branch (4.15.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-44104](https://issues.redhat.com//browse/OCPBUGS-44104) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-44104](https://issues.redhat.com//browse/OCPBUGS-44104) targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1207#issuecomment-2473480847): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jmencak commented 1 week ago

@liqcui , can we please have the cherry-pick-approved label? Thank you!

liqcui commented 1 week ago

/label cherry-pick-approved

openshift-ci[bot] commented 1 week ago

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 week ago

@jmencak: Jira Issue OCPBUGS-44275: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44275 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1207): >This is a manual backport of #1203. > >When using a PerformanceProfile, a TuneD scheduler was setting sched_migration_cost_ns. This setting was previously used by throughput-performance and latency-performance profiles. However, it was dropped from these profiles based on performance evaluation for RHEL-9 as discussed in rhbz#1957829. > >Setting sched_migration_cost_ns causes issues when SecureBoot/kernel_lockdown is in effect. Do not set this tunable when using PerformanceProfiles. > >Resolves: OCPBUGS-44275 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 week ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator This PR has been included in build cluster-node-tuning-operator-container-v4.15.0-202411131634.p0.g4010bec.assembly.stream.el9. All builds following this will include this PR.

openshift-merge-robot commented 1 week ago

Fix included in accepted release 4.15.0-0.nightly-2024-11-14-004838