search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

OCPBUGS-44283: right-hand-side profile_dirs take precedence #1208

Closed jmencak closed 2 weeks ago

jmencak commented 2 weeks ago

This is a manual backport of #1061.

The new TuneD option profile_dirs defines custom TuneD directories. Fix the order of the directories so that the system TuneD directory (/usr/lib/tuned) is the first one (searched last), and the custom TuneD directory (/var/lib/ocp-tuned/profiles) is the last one (searched first).

Resolves: OCPBUGS-44283

openshift-ci-robot commented 2 weeks ago

@jmencak: This pull request references Jira Issue OCPBUGS-44283, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.z) matches configured target version for branch (4.15.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-35208](https://issues.redhat.com//browse/OCPBUGS-35208) is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-35208](https://issues.redhat.com//browse/OCPBUGS-35208) targets the "4.16.0" version, which is one of the valid target versions: 4.16.0, 4.16.z * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1208): >This is a manual backport of #1061. > >The new TuneD option profile_dirs defines custom TuneD directories. Fix the order of the directories so that the system TuneD directory (/usr/lib/tuned) is the first one (searched last), and the custom TuneD directory (/var/lib/ocp-tuned/profiles) is the last one (searched first). > >Resolves: OCPBUGS-44283 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/release-4.15/OWNERS)~~ [jmencak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 weeks ago

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
liqcui commented 2 weeks ago

/lgtm

liqcui commented 2 weeks ago

/label cherry-pick-approved

jmencak commented 2 weeks ago

/label backport-risk-assessed

openshift-ci-robot commented 2 weeks ago

@jmencak: Jira Issue OCPBUGS-44283: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44283 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1208): >This is a manual backport of #1061. > >The new TuneD option profile_dirs defines custom TuneD directories. Fix the order of the directories so that the system TuneD directory (/usr/lib/tuned) is the first one (searched last), and the custom TuneD directory (/var/lib/ocp-tuned/profiles) is the last one (searched first). > >Resolves: OCPBUGS-44283 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jmencak commented 2 weeks ago

/cherry-pick release-4.14

openshift-cherrypick-robot commented 2 weeks ago

@jmencak: new pull request created: #1210

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1208#issuecomment-2461384048): >/cherry-pick release-4.14 > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator This PR has been included in build cluster-node-tuning-operator-container-v4.15.0-202411070608.p0.gc6b42c6.assembly.stream.el9. All builds following this will include this PR.

openshift-merge-robot commented 2 weeks ago

Fix included in accepted release 4.15.0-0.nightly-2024-11-07-071656