search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

NO-JIRA: PPC: fix error message #1223

Closed shajmakh closed 12 hours ago

shajmakh commented 1 day ago

Copy-paste mistake in reporting the difference in logical processors list; replace .NumThreads with .LogicalProcessors.

jmencak commented 1 day ago

/lgtm /approve

jmencak commented 1 day ago

@shajmakh Unless you have a Jira, I suggest to retitle to NO-JIRA: ...

openshift-ci-robot commented 1 day ago

@shajmakh: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/1223): >Copy-paste mistake in reporting the difference in logical processors list; replace `.NumThreads` with `.LogicalProcessors`. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jmencak commented 1 day ago

/retest

openshift-ci[bot] commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, jmencak, shajmakh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [ffromani,jmencak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jmencak commented 23 hours ago

This will help us getting correct information during customer case investigations. /label acknowledge-critical-fixes-only

openshift-ci-robot commented 19 hours ago

/retest-required

Remaining retests: 0 against base HEAD 5f84739dea49e04d5c0957c1c023991e20a80668 and 2 for PR HEAD a5f38957416b0b3fe913943f66668951aef92f1d in total

jmencak commented 14 hours ago

/retest

openshift-ci[bot] commented 12 hours ago

@shajmakh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 8 hours ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-node-tuning-operator This PR has been included in build cluster-node-tuning-operator-container-v4.19.0-202411221136.p0.g7323f74.assembly.stream.el9. All builds following this will include this PR.