search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

CNF-10170: Render MC without additional PP #924

Closed jlojosnegros closed 10 months ago

jlojosnegros commented 10 months ago

This command should render a MC from the available sources. PerformanceProfile is a source, but it is not mandatory.

So, as there are scenarios where this command should work with no additional PP let's the command proceed even if there is no PP

yanirq commented 10 months ago

The meaning of "additional" is a bit obscured here ? Can we use the render command without a performance profile at all ?

jlojosnegros commented 10 months ago

The meaning of "additional" is a bit obscured here ? Can we use the render command without a performance profile at all ?

Well per the last discussion we had, yes. This render command should render a MC with the kernel args from all available sources. PerformanceProfile is another source but not a mandatory one.

Please @MarSik keep me honest here.

MarSik commented 10 months ago

@yanirq Yep, it is a tuned render after all. We only need to know the perf profiles to be able to collect all the generated tuned objects. But when there are no extra tuneds, NTO still ships the stock openshift-node Tuned with the proper recommendation selectors.

So the logic still works fine, even though there are no extra kernel args atm.

openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlojosnegros, MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [MarSik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jlojosnegros commented 10 months ago

/test e2e-aws-ovn-techpreview

jlojosnegros commented 10 months ago

/test e2e-gcp-pao-updating-profile

openshift-ci-robot commented 10 months ago

@jlojosnegros: This pull request references CNF-10170 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.15" instead.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/924): >This command should render a MC from the available sources. PerformanceProfile is a source, but it is not mandatory. > >So, as there are scenarios where this command should work with no additional PP let's the command proceed even if there is no PP Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 10 months ago

/retest-required

Remaining retests: 0 against base HEAD fd8b0be063fd25447b24f8333d0d2c6c396fff53 and 2 for PR HEAD a50a527d1cc765f9413613be0df75bb74937eadc in total

jlojosnegros commented 10 months ago

/hold Need to rebase once #929 is merged.

jlojosnegros commented 10 months ago

/hold cancel as #929 has been already merged.

jlojosnegros commented 10 months ago

/test e2e-gcp-pao-updating-profile

jlojosnegros commented 10 months ago

/label acknowledge-critical-fixes-only

openshift-ci[bot] commented 10 months ago

@jlojosnegros: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 10 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202401302041.p0.g74ecaaa.assembly.stream for distgit cluster-node-tuning-operator. All builds following this will include this PR.