search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

CNF-10170: Avoid command to fail if there is no PP on input folders #935

Closed jlojosnegros closed 9 months ago

jlojosnegros commented 9 months ago

When there is no enough information to choose a recommended TuneD profile from the input folder manifests we load the default-cr-tuned manifests.

modifies: #844 see: https://github.com/openshift/installer/pull/8007

openshift-ci-robot commented 9 months ago

@jlojosnegros: This pull request references CNF-10170 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.15" instead.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/935): >To be able to choose properly the recommended profile we need to have the default tuned profiles loaded. >As this command is intended to be run in bootstrap we need to read them from the file system. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jlojosnegros commented 9 months ago

/cc @MarSik @vitus133

jlojosnegros commented 9 months ago

/hold

jlojosnegros commented 9 months ago

/test e2e-hypershift

openshift-ci-robot commented 9 months ago

@jlojosnegros: This pull request references CNF-10170 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.15" instead.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/935): >When there is no enough information to choose a recommended TuneD profile from the input folder manifests we load the `default-cr-tuned` manifests. > >modifies: #844 >see: https://github.com/openshift/installer/pull/8007 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jlojosnegros commented 9 months ago

/test e2e-aws-ovn-techpreview

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlojosnegros, MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [MarSik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
MarSik commented 9 months ago

/lgtm

jlojosnegros commented 9 months ago

/hold cancel

openshift-ci-robot commented 9 months ago

/retest-required

Remaining retests: 0 against base HEAD d7c3111b261fb58963a1bf184ca1c014a1f4fcd6 and 2 for PR HEAD ef12f0c9004a825ff8c5e36cd1fd89b3b657d468 in total

vitus133 commented 9 months ago

/hold

jlojosnegros commented 9 months ago

/hold @vitus133 found a possible issue -> reviewing

vitus133 commented 9 months ago

/retest /unhold

vitus133 commented 9 months ago

/retest

openshift-ci-robot commented 9 months ago

/retest-required

Remaining retests: 0 against base HEAD abfe49231dbdf4d7dfedbf82adc7234497d5d858 and 1 for PR HEAD ef12f0c9004a825ff8c5e36cd1fd89b3b657d468 in total

vitus133 commented 9 months ago

/test e2e-hypershift

jlojosnegros commented 9 months ago

/test e2e-hypershift

jlojosnegros commented 9 months ago

/retest

openshift-ci-robot commented 9 months ago

/retest-required

Remaining retests: 0 against base HEAD 19686cd969404eca0bf09f9c991a8e7bd7ea0ad2 and 0 for PR HEAD ef12f0c9004a825ff8c5e36cd1fd89b3b657d468 in total

openshift-ci-robot commented 9 months ago

/hold

Revision ef12f0c9004a825ff8c5e36cd1fd89b3b657d468 was retested 3 times: holding

jlojosnegros commented 9 months ago

/test e2e-aws-ovn-techpreview /hold cancel

openshift-ci-robot commented 9 months ago

/retest-required

Remaining retests: 0 against base HEAD 19686cd969404eca0bf09f9c991a8e7bd7ea0ad2 and 2 for PR HEAD ef12f0c9004a825ff8c5e36cd1fd89b3b657d468 in total

yanirq commented 9 months ago

/retest-required

openshift-ci[bot] commented 9 months ago

@jlojosnegros: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 9 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202402261639.p0.ge7ff8d5.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.

openshift-merge-robot commented 8 months ago

Fix included in accepted release 4.14.0-0.nightly-2024-03-19-212806