search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

NO-JIRA: e2e: classifying tests using labels #936

Closed Tal-or closed 9 months ago

Tal-or commented 9 months ago

The label package contains a list of labels that can be used in the functests to indicate and point certain behavior or characteristics of the various tests.

Those can be filtered/focused by ginkgo before the test runs.

Example: ginkgo --label-filter="!slow" means avoid any specs labelled slow

ffromani commented 9 months ago

/approve

I very much like the idea

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [ffromani] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mrniranjan commented 9 months ago

lgtm from my side

mrniranjan commented 9 months ago

/lgtm

mrniranjan commented 9 months ago

since we wanted to backport this, i think we need either NO-JIRA or a bug.

openshift-ci-robot commented 9 months ago

@Tal-or: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/936): >The label package contains a list of labels that can be used in the functests to indicate and point certain behavior or characteristics of the various tests. > >Those can be filtered/focused by ginkgo before the test runs. > >Example: >`ginkgo --label-filter="!slow"` means avoid any specs labelled `slow` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Tal-or commented 9 months ago

since we wanted to backport this, i think we need either NO-JIRA or a bug.

Backport means we should also add labels to all test and backport that as well

mrniranjan commented 9 months ago

since we wanted to backport this, i think we need either NO-JIRA or a bug.

Backport means we should also add labels to all test and backport that as well

Right , should we do that in separate PR's because we need to decide which tests gets what labels, Some tests may have multiple labels.

openshift-ci[bot] commented 9 months ago

@Tal-or: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
Tal-or commented 9 months ago

/cherry-pick release-4.15

openshift-cherrypick-robot commented 9 months ago

@Tal-or: new pull request created: #943

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/936#issuecomment-1934467040): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.