openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

NO-JIRA: Fix e2e tests on SNO #939

Closed jmencak closed 9 months ago

jmencak commented 9 months ago

PR459 made adjustments to fix NTO e2e tests on SNO. Unfortunately, the PR did not include 4 SNO manifests to test with. This change fixes this issue.

openshift-ci[bot] commented 9 months ago

@jmencak: GitHub didn't allow me to request PR reviews from the following users: jmencak.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/939): >[PR459](https://github.com/openshift/cluster-node-tuning-operator/pull/459) made adjustments to fix NTO e2e tests on SNO. Unfortunately, the PR did not include 4 SNO manifests to test with. This change fixes this issue. > >/cc > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [jmencak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 9 months ago

@jmencak: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/939): >[PR459](https://github.com/openshift/cluster-node-tuning-operator/pull/459) made adjustments to fix NTO e2e tests on SNO. Unfortunately, the PR did not include 4 SNO manifests to test with. This change fixes this issue. > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jmencak commented 9 months ago

/retest

Tal-or commented 9 months ago

/lgtm

openshift-ci-robot commented 9 months ago

/retest-required

Remaining retests: 0 against base HEAD edb0f9af7ee9fd0db30b4db4070b1d28369290ef and 2 for PR HEAD f2ad795b9c43178417891773b4459f7da96e8c02 in total

openshift-ci[bot] commented 9 months ago

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 9 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202402090109.p0.gac0f8bd.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.