search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

OCPBUGS-29183: e2e: when crun is enabled by default skip checking runc config #948

Closed mrniranjan closed 7 months ago

mrniranjan commented 9 months ago

This patch fixes runc configuration test which was failing when crun is configured prior to running the test

In this patch we move BeforeAll at the context level to check if any container runtime is pre configured

if crun is preconfigured: skip runc config test if crun is not preconfigured: check runc configuration and in the subsequent test, we enable crun and test crun and delete crun configuration

openshift-ci-robot commented 9 months ago

@mrniranjan: This pull request references Jira Issue OCPBUGS-29183, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (mniranja@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/948): >This patch fixes runc configuration test which >was failing when crun is configured prior to running the test > >In this patch we move BeforeAll at the context level to check if any container runtime is pre configured > >if crun is preconfigured: skip runc config test >if crun is not preconfigured: check runc configuration and in the subsequent test, we enable crun and test crun and delete crun configuration Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
mrniranjan commented 9 months ago

it seems to me this works only if a specific test order is used. Is that the case?

Yes tests are ordered.

ffromani commented 9 months ago

/approve

let's keep looking for balance between test isolation and wall clock execution time

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, mrniranjan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [ffromani] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
shajmakh commented 8 months ago

Thanks for this. /lgtm /hold for other reviewers, please unhold as you see fit.

ffromani commented 7 months ago

/hold cancel

LGTM as well, but I concur with @Tal-or : we should have more lanes configured accordingly. Capacity is a concern, though.

openshift-ci[bot] commented 7 months ago

@mrniranjan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 7 months ago

@mrniranjan: Jira Issue OCPBUGS-29183: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29183 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/948): >This patch fixes runc configuration test which >was failing when crun is configured prior to running the test > >In this patch we move BeforeAll at the context level to check if any container runtime is pre configured > >if crun is preconfigured: skip runc config test >if crun is not preconfigured: check runc configuration and in the subsequent test, we enable crun and test crun and delete crun configuration Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
mrniranjan commented 7 months ago

/cherry-pick release-4.15

openshift-cherrypick-robot commented 7 months ago

@mrniranjan: #948 failed to apply on top of branch "release-4.15":

Applying: e2e: when crun is enabled by default skip checking runc config
Using index info to reconstruct a base tree...
M   test/e2e/performanceprofile/functests/2_performance_update/updating_profile.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/performanceprofile/functests/2_performance_update/updating_profile.go
CONFLICT (content): Merge conflict in test/e2e/performanceprofile/functests/2_performance_update/updating_profile.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 e2e: when crun is enabled by default skip checking runc config
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/948#issuecomment-2033507249): >/cherry-pick release-4.15 > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.