search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

OCPBUGS-29546: Apply hypershift cluster-profile for ibm-cloud-managed #958

Closed openshift-art-build-bot closed 9 months ago

openshift-art-build-bot commented 9 months ago

Since HyperShift / Hosted Control Plane have adopted include.release.openshift.io/ibm-cloud-managed, to tailor the resources of clusters running in the ROKS IBM environment, the include.release.openshift.io/hypershift addition will allow Hypershift to express different profile choices than ROKS

openshift-ci-robot commented 9 months ago

@openshift-art-build-bot: This pull request references Jira Issue OCPBUGS-29546, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (liqcui@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/958): >Since HyperShift / Hosted Control Plane have adopted `include.release.openshift.io/ibm-cloud-managed`, to tailor the resources of clusters running in the ROKS IBM environment, the `include.release.openshift.io/hypershift` addition will allow Hypershift to express different profile choices than ROKS Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ashwindasr commented 9 months ago

If config needs to be updated in other files as well, please let me know

jmencak commented 9 months ago

If config needs to be updated in other files as well, please let me know

/cc @jlojosnegros

jmencak commented 9 months ago

/approve Thank you for the PR, @ashwindasr , the verify job needs to be fixed.

ashwindasr commented 9 months ago

Thanks @jmencak

Updated the order, but looks like the line is being rejected. I'm assuming the config flows from another file?

jmencak commented 9 months ago

Thanks @jmencak

Updated the order, but looks like the line is being rejected. I'm assuming the config flows from another file?

Yeah, you fixed it for most files. The 50-operator-ibm-cloud-managed.yaml is auto-generated from profile-patches/ibm-cloud-managed, so you'd need to add the annotation to 50-operator.yaml-patch. What is the point here, to have the annotations both in regular OCP (50-operator.yaml) and in the IBM ROKS environment (50-operator-ibm-cloud-managed.yaml)? I'm assuming only one of the 50-operator* files. The 50-operator-ibm-cloud-managed.yaml one?

ashwindasr commented 9 months ago

@jmencak The reason for opening this PR has been outlined in https://issues.redhat.com/browse/ART-8431.

In short, any manifest that has the ibm-managed annotation, should also have new hypershift annotation as well.

ashwindasr commented 9 months ago

Also if its easier, I'll yield this PR to you and/or your team, if there are complicated changes required to achieve this goal. But if its just adding another line to the patch file, I can make the change.

jmencak commented 9 months ago

Thank you for the PR, it makes sense to me now. /lgtm /approve

openshift-ci[bot] commented 9 months ago

@openshift-art-build-bot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 9 months ago

@jmencak: The label(s) /label acknowledge-critical-fixes-only, cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/958#issuecomment-1953076349): >/label acknowledge-critical-fixes-only, > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jmencak commented 9 months ago

/label acknowledge-critical-fixes-only

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, openshift-art-build-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [jmencak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 9 months ago

@openshift-art-build-bot: Jira Issue OCPBUGS-29546: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29546 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/958): >Since HyperShift / Hosted Control Plane have adopted `include.release.openshift.io/ibm-cloud-managed`, to tailor the resources of clusters running in the ROKS IBM environment, the `include.release.openshift.io/hypershift` addition will allow Hypershift to express different profile choices than ROKS Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 9 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202402192309.p0.g80fe851.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.

openshift-merge-robot commented 9 months ago

Fix included in accepted release 4.16.0-0.nightly-2024-02-22-021321