search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

OCPBUGS-29934: Add support to inject owner-ref argument to render command #960

Closed rbaturov closed 9 months ago

rbaturov commented 9 months ago

We need this change because we also want to use also non default values for the owner-ref like the value none. The work on this PR depends on these modifications to be merged.

rbaturov commented 9 months ago

@Tal-or @ffromani

ffromani commented 9 months ago

this works, but IMO it should work the other way around: the owner-ref should be on by default, and opted-out only in the few (currently, exactly one and only) cases which don't need it

rbaturov commented 9 months ago

/retest-required

ffromani commented 9 months ago

LGTM how do we test this change?

Tal-or commented 9 months ago

LGTM how do we test this change?

There was a test which was failing and exposed the issue. if the test will pass then it mean we're out of the woods

ffromani commented 9 months ago

/approve /lgtm

per https://github.com/openshift/cluster-node-tuning-operator/pull/960#issuecomment-1954175713

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, rbaturov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [ffromani] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ffromani commented 9 months ago

/label acknowledge-critical-fixes-only

ffromani commented 9 months ago

this PR won't affect the payload

ffromani commented 9 months ago

/retitle NO-JIRA: Add support to inject owner-ref argument to render command

openshift-ci-robot commented 9 months ago

@rbaturov: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/960): > We need this change because we also want to use also non default values for the owner-ref like the value none. > The work on [this PR depends](https://github.com/openshift/cluster-node-tuning-operator/pull/954) on these modifications to be merged. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rbaturov commented 9 months ago

/retest-required

openshift-ci[bot] commented 9 months ago

@rbaturov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 9 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202402210139.p0.g631e03c.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.

rbaturov commented 9 months ago

/cherry-pick release-4.15

openshift-cherrypick-robot commented 9 months ago

@rbaturov: new pull request created: #966

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/960#issuecomment-1956643388): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 9 months ago

@rbaturov: Jira Issue OCPBUGS-29934: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29934 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/960): > We need this change because we also want to use also non default values for the owner-ref like the value none. > The work on [this PR depends](https://github.com/openshift/cluster-node-tuning-operator/pull/954) on these modifications to be merged. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rbaturov commented 9 months ago

/cherry-pick release-4.14

openshift-cherrypick-robot commented 9 months ago

@rbaturov: #960 failed to apply on top of branch "release-4.14":

Applying: Add support to inject owner-ref argument to render command
Using index info to reconstruct a base tree...
M   hack/render-sync.sh
Falling back to patching base and 3-way merge...
Auto-merging hack/render-sync.sh
CONFLICT (content): Merge conflict in hack/render-sync.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add support to inject owner-ref argument to render command
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/960#issuecomment-1968942697): >/cherry-pick release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.