search

openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

CNF-11213: added mixedCpus e2e test #967

Closed rbaturov closed 8 months ago

rbaturov commented 9 months ago

Added a test for mixedCpus feature along with some util functions. This test checks that pods using shared CPUs in a deployment won't be able to schedule after the mixedCpus feature is disabled and the node reboots.

openshift-ci-robot commented 9 months ago

@rbaturov: This pull request references CNF-11213 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/967): >Added a test for mixedCpus feature along with some util functions. >This test checks that pods using shared CPUs in a deployment won't >be able to schedule after the mixedCpus feature is disabled and the node reboots. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rbaturov commented 9 months ago

/hold

rbaturov commented 9 months ago

/retest-required

rbaturov commented 8 months ago

/retest-required

rbaturov commented 8 months ago

/retest-required

Tal-or commented 8 months ago

/lgtm

Great work here, thank you @rbaturov

rbaturov commented 8 months ago

/unhold

rbaturov commented 8 months ago

/retest-required

rbaturov commented 8 months ago

/retest-required

rbaturov commented 8 months ago

/retest-required

rbaturov commented 8 months ago

/retest-required

rbaturov commented 8 months ago

/retest-required

Tal-or commented 8 months ago

/lgtm /approve

openshift-ci[bot] commented 8 months ago

@rbaturov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
yanirq commented 8 months ago

/lgtm

yanirq commented 8 months ago

/approve

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rbaturov, Tal-or, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [yanirq] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 8 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202403242314.p0.gd46c828.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.