openshift / cluster-node-tuning-operator

Manage node-level tuning by orchestrating the tuned daemon.
Apache License 2.0
102 stars 105 forks source link

NO-JIRA: Remove RELEASE_VERSION from test-upstream-tuned.sh #969

Closed jmencak closed 8 months ago

jmencak commented 9 months ago

Starting with PR858, we can no longer use a random RELEASE_VERSION to trigger daemonset/operand updates. In the context of testing upstream TuneD this is causes an issue. Not changing RELEASE_VERSION at all is a simple fix, because we are also adjusting CLUSTER_NODE_TUNED_IMAGE and that will cause a daemonset/operand update.

openshift-ci-robot commented 9 months ago

@jmencak: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/969): >Starting with PR858, we can no longer use a random RELEASE_VERSION to trigger daemonset/operand updates. In the context of testing upstream TuneD this is causes an issue. Not changing RELEASE_VERSION at all is a simple fix, because we are also adjusting CLUSTER_NODE_TUNED_IMAGE and that will cause a daemonset/operand update. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-node-tuning-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jmencak commented 9 months ago

Tested with the latest TuneD 2.22.1 which will be the next FDP release.

jmencak commented 9 months ago

/retest

jmencak commented 9 months ago

Infra issues /retest

jmencak commented 8 months ago

/retest /cc @liqcui

jmencak commented 8 months ago

There's no way this can break ci/prow/e2e-gcp-pao /retest

jmencak commented 8 months ago

/override ci/prow/e2e-gcp-pao

jmencak commented 8 months ago

/retest

openshift-ci[bot] commented 8 months ago

@jmencak: Overrode contexts on behalf of jmencak: ci/prow/e2e-gcp-pao

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/969#issuecomment-1983600718): >/override ci/prow/e2e-gcp-pao > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ffromani commented 8 months ago

/lgtm /hold

holding to let other reviewers chime in, feel free to remove anytime

jmencak commented 8 months ago

/hold cancel

MarSik commented 8 months ago

/approve /lgtm

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-node-tuning-operator/blob/master/OWNERS)~~ [MarSik,jmencak] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 8 months ago

/retest-required

Remaining retests: 0 against base HEAD 03f95571187560f7ce4b2175d00bbb3e1ae7bffd and 2 for PR HEAD 9e8d3418671c19277601a0a4b7f1a89621f2c22b in total

jmencak commented 8 months ago

/override ci/prow/e2e-gcp-pao-updating-profile /retest

openshift-ci[bot] commented 8 months ago

@jmencak: Overrode contexts on behalf of jmencak: ci/prow/e2e-gcp-pao-updating-profile

In response to [this](https://github.com/openshift/cluster-node-tuning-operator/pull/969#issuecomment-1984450733): >/override ci/prow/e2e-gcp-pao-updating-profile >/retest > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 8 months ago

@jmencak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 8 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-node-tuning-operator-container-v4.16.0-202403081048.p0.gf9c912b.assembly.stream.el9 for distgit cluster-node-tuning-operator. All builds following this will include this PR.